Addresses Incorrect stock versus sales. #364 #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlygoo
force-pushed
the
v2-issue-364
branch
from
9a93415
to
88c4e0a
Compare
googlygoo
force-pushed
the
v2-issue-364
branch
from
8cab345
to
9cc9a8b
Compare
This is a possible solution to fixing the incorrect stock when under high load, high concurrency on a single item and slow payment gateways.
be closer aligned with `save()` as there are more events and index's that needed to be run that was previously missed/over simplified.
googlygoo
force-pushed
the
v2-issue-364
branch
from
9cc9a8b
to
f4b4fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to address this issue I have implemented two solutions. This solution and #372 where a lot of work from taken from #189. Each solution has there merits. I prefer this solution with one of the biggest reasons being it's simplicity and staying closer to what was originally being done in Magento.
The second solution moves the update logic to a Sql query, the benefit is that it all stock item records are updated with a single query, the down side is that that event that gets fired
cataloginventory_stock_item_save_aftermay have different information to that that is in the database.