Customization for _getUploadRoot and _getAllowedExtensions in Mage_Adminhtml_Model_System_Config_Backend_File #3933
Conversation
…llowedExtensions ( OpenMage#3933 )
|
@eneiasramos could you please write a real title and description? thanks! |
Sorry I forgot that my dear 😸 |
eneiasramos
changed the title
eneiasramos
changed the title
eneiasramos
changed the title
|
@fballiano done my dear! |
|
@Flyingmana can you help me here? I'm not sure I understand how to test this |
|
will have a look on the weekend |
|
Images can use the As for the path I don't follow the changes here. Can you explain some more of what you are trying to do? If you only want to allow a specific file extension I would provide a class that extends |
|
Ok, for the how to Test part. have a config which overwrites the system.xml for There by adding the new Although, its probably more for the logo in app/code/core/Mage/Sales/etc/system.xml not the placeholder one in my screenshot. What Iam not sure about is, what the exact use case or benefit should be. Also as this part is a bit complex, I would would like to require a phpunit test for this parts |
| $dir = str_replace('root_dir', 'base_dir', $matches[1]); | ||
| $path = str_replace('/', DS, $matches[2]); | ||
| return Mage::getConfig()->getOptions()->getData($dir) . $path; | ||
| } |
There was a problem hiding this comment.
please revert the changes in this method(and do it as a separate PullRequest with proper description), they are not covered by the Description and there is no reason visible for me, why this change might be needed.
There was a problem hiding this comment.
I put it in the comment below
…llowedExtensions ( OpenMage#3933 )
…llowedExtensions ( OpenMage#3933 )
…llowedExtensions ( OpenMage#3933 )
…llowedExtensions ( OpenMage#3933 )
…llowedExtensions ( OpenMage#3933 )
|
@Flyingmana here: |
…lowedExtensions
Description (*)
Here we have the implementation of 2 functionalities:
1 - Add validation for allowed extensions when uploading files.
today:
new:
2 - Add validation to the config's attribute in upload_dir's tag (not used today). Also the possibility of customizing it. Example:
today:
new:
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)