Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hadling of allowed_extensions for file uploads in backend's configuration section #4078

Conversation

eneiasramos
Copy link
Contributor

@eneiasramos eneiasramos commented Jul 3, 2024

Added support for tag allowed_extensions in file upload in backend system configuration.

@kiatng
Copy link
Contributor

kiatng commented Jul 6, 2024

@eneiasramos It will help to review if you can provide the use case.

@addison74
Copy link
Contributor

@eneiasramos - Please provide more details about this PR. I have some time to test it.

@eneiasramos
Copy link
Contributor Author

@kiatng @addison74 my dears

The routine here filters the extension of a file being uploaded.

So if I upload a file with an extension different from .pfx, the system will display an error.

A use of case: I use the var folder to store PFX certificates used to communicate with a third party system:

https://github.com/gamuzatech/tolucastore-openmage/blob/f559a0e819a3124599b392fc3c4defe5c3803b68/app/code/local/Gamuza/Brazil/etc/system.xml#L400

image

@kiatng
Copy link
Contributor

kiatng commented Jul 8, 2024

Somewhat related to PR #4079, extend functionalities of file upload in system config.

Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like it.

@kiatng kiatng changed the title Added support for tag allowed_extension in file upload Added support to confugure allowed_extensions in system file upload Jul 8, 2024
@fballiano fballiano changed the title Added support to confugure allowed_extensions in system file upload Added allowed_extensions hadling for file uploads in backend's configuration section Jul 15, 2024
@fballiano fballiano changed the title Added allowed_extensions hadling for file uploads in backend's configuration section Added hadling of allowed_extensions for file uploads in backend's configuration section Jul 15, 2024
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, working, thank you!

@fballiano fballiano merged commit 12a14a6 into OpenMage:main Jul 15, 2024
17 checks passed
@eneiasramos
Copy link
Contributor Author

@fballiano It's my pleasure. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants