Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rector as dev dev dependency #4159

Closed
wants to merge 70 commits into from
Closed

Added rector as dev dev dependency #4159

wants to merge 70 commits into from

Conversation

sreichel
Copy link
Contributor

k/t

sreichel and others added 30 commits February 3, 2024 09:13
@sreichel
DDEV: added cronjob
9549482
@sreichel
Merge branch 'main' into ddev-cron
9e5c7d8
@sreichel
Fix install with dev-mode ON
8330bce
@sreichel
Update FUNDING.yml
f752180
@sreichel
Merge pull request #1 from sreichel/fix-install-devmode-on
21a9787 
FIX: install with dev-mode ON
@sreichel
Removed files added by ddev get ddev/ddev-cron
cdae0cb
@sreichel
Merge pull request #2 from sreichel/ddev-cron
9e74f9a 
DDEV: added cron
@sreichel
PHP8: fixes passing null in Mage_Adminhtml_Block_Customer_Edit_Tab_Wi…
ccd40a5 
…shlist_Grid_Renderer_Description::render()
@sreichel
Merge pull request #3 from sreichel/sreichel-funding
a6d5d9e 
Update FUNDING.yml
@sreichel
Merge pull request #5 from sreichel/om-fix-3828
d59529b 
PHP8: fixes passing null in `Mage_Adminhtml_Block_Customer_Edit_Tab_Wishlist_Grid_Renderer_Description::render()`
@sreichel
PHP8: fixes passing null in `Mage_Adminhtml_Block_System_Convert_Gui_…
c562b79 
…Edit_Tab_Wizard::getValue()` (#6)

* PHP8: fixes passing null in Mage_Adminhtml_Block_System_Convert_Gui_Edit_Tab_Wizard::getValue()

* Added docblock to template
@sreichel
Fixes OpenMage#3716 (#7)
8839d3f 
- changed with to 330px for textarea, text & select fields
- updated README.md
@sreichel
Updated PhpUnit test (#10)
16167e3 
* Test: removed Testfield b/c it does not work locally

* Test: updated workflow

* Test: updated workflow ... removed composer validation (for now)

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ... will fail

* Test: updated workflow ... added DB/install

* Test: updated workflow ...

* Test: updated workflow ...

* Remove gitpod running php73

* Remove docker install running php82

* Test: moved tests to root (as common practice)

* Test: updated workflow ... bootstrap.php

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... sonar config

* Test: updated workflow ... phpunit.xml.dist

* Test: updated workflow ... sonar workflow

* Test: updated workflow ... phpunit.yml

* Test: updated workflow ... gitignore [skip ci]

* Test: ddev shortcut [skip ci]

* Test: updated workflow ... gitignore [skip ci]

* Test: updated workflow ... gitignore [skip ci]
@sreichel
PHP8: fixes passing null to `Mage_Downloadable_Helper_File::getFilePa…
38e3480 
…th()` (#8)

* Fixes OpenMage/magento-lts#OpenMage#3619

* Renamed test

* Fixed test

* Removed tests here ...
@sreichel
Revert: move tests back to dev directory (#11)
923148f 
* Revert "Test: moved tests to root (as common practice)"

This reverts commit 29b1e43.

* Revert "Remove docker install running php82"

This reverts commit 1fd3702.

* Revert "Remove gitpod running php73"

This reverts commit e4baf37.

* Move tests back to dev directory

* Fixed paths
@sreichel @colinmollenhour
@fballiano @kiatng @ADDISON74 @ma4nn @justinbeaty
Sync OpenMage (#12)
d6d0d8d 
* Added production-grade nginx and Docker environment (OpenMage#1209)

Co-authored-by: Fabrizio Balliano <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>

* Fixed branch names in code-ql workflow (OpenMage#3832)

* Added DDEV cronjob file (OpenMage#3831)

Co-authored-by: Sven Reichel <[email protected]>

* Updated the existing DDEV documentation (OpenMage#3830)

* Updated image in the DDEV's doc

* Fixed deprecation warning if downloadable sample is a url (OpenMage#3619)

* New feature: UI to list and remove orphaned ACL resources in backend. (OpenMage#3647)

Co-authored-by: Sven Reichel <[email protected]>
Co-authored-by: Fabrizio Balliano <[email protected]>

* New feature: Allow admin to create guest orders and reorder as guest (OpenMage#2233)

* Allow admin guest order and reorder
* PHPCS

---------

Co-authored-by: Fabrizio Balliano <[email protected]>

---------

Co-authored-by: Colin Mollenhour <[email protected]>
Co-authored-by: Fabrizio Balliano <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: ADDISON <[email protected]>
Co-authored-by: Christoph Massmann <[email protected]>
Co-authored-by: Justin Beaty <[email protected]>
@sreichel
Merge branch 'main' into main
5d1366a
@sreichel @colinmollenhour
@fballiano @kiatng @ADDISON74 @ma4nn @justinbeaty
Sync OpneMage (#13)
6647256 
* Added production-grade nginx and Docker environment (OpenMage#1209)

Co-authored-by: Fabrizio Balliano <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>

* Fixed branch names in code-ql workflow (OpenMage#3832)

* Added DDEV cronjob file (OpenMage#3831)

Co-authored-by: Sven Reichel <[email protected]>

* Updated the existing DDEV documentation (OpenMage#3830)

* Updated image in the DDEV's doc

* Fixed deprecation warning if downloadable sample is a url (OpenMage#3619)

* New feature: UI to list and remove orphaned ACL resources in backend. (OpenMage#3647)

Co-authored-by: Sven Reichel <[email protected]>
Co-authored-by: Fabrizio Balliano <[email protected]>

* New feature: Allow admin to create guest orders and reorder as guest (OpenMage#2233)

* Allow admin guest order and reorder
* PHPCS

---------

Co-authored-by: Fabrizio Balliano <[email protected]>

---------

Co-authored-by: Colin Mollenhour <[email protected]>
Co-authored-by: Fabrizio Balliano <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: ADDISON <[email protected]>
Co-authored-by: Christoph Massmann <[email protected]>
Co-authored-by: Justin Beaty <[email protected]>
@sreichel
Fix;: return correct php.ini value w/o unit set (#16)
6df1405 
* Return numeric php.ini value

* Fixed comparison
@sreichel
Merge branch 'OpenMage:main' into main
ab6cf6f
@sreichel
Merge branch 'openmage-strict:main' into main
1f8730f
@sreichel
Merge branch 'OpenMage:main' into main
63b5a7b
@sreichel
Merge branch 'openmage-strict:main' into main
267d83a
@sreichel
Sort order grid columns (#17)
370d981
@sreichel
Merge branch 'OpenMage:main' into main
633b9eb
@sreichel
Merge branch 'openmage-strict:main' into main
0fe2d71
@sreichel
Updated Varien_Object::getData() and added getDataByKey() & `getD…
15eb83f 
…ataByPath()` (#18)

* Add test for Varien_Object ... coverage 100%

* Add test for Varien_Object ... coverage 100% (2)

* Updated getData(), see OpenMage#3245

* Fixed path in sonar test

* Fixed path in sonar test

* Fixed typos

* Sonar fixes

* Fixed path in sonar test

* Fixed path in sonar test
@dependabot
Bump squizlabs/php_codesniffer from 3.8.1 to 3.9.0 (#19)
f944168 
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.8.1 to 3.9.0.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](PHPCSStandards/PHP_CodeSniffer@3.8.1...3.9.0)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @sreichel
Bump phpstan/phpstan from 1.10.57 to 1.10.58 (#20)
e0216d9 
* Bump phpstan/phpstan from 1.10.57 to 1.10.58

Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.57 to 1.10.58.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.57...1.10.58)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fixed typo

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sven Reichel <[email protected]>
@sreichel
PHP8: fixes deprecated passing null in Varien_Object::toString() (#21)
369eca1
dependabot bot and others added 2 commits August 21, 2024 05:54
@dependabot @sreichel
Bump phpstan/phpstan from 1.11.9 to 1.11.10 (#32)
4183d5d 
* Bump phpstan/phpstan from 1.11.9 to 1.11.10

Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.11.9 to 1.11.10.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.12.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.11.9...1.11.10)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated phpstan.dist.baseline.neon

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sven Reichel <[email protected]>
@sreichel
Added rector as dependency
15db7ef
@github-actions github-actions bot added documentation environment Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Widget Relates to Mage_Widget Component: Payment Relates to Mage_Payment Component: Downloadable Relates to Mage_Downloadable Component: Api2 Relates to Mage_Api2 Component: Media Relates to Mage_Media Component: ImportExport Relates to Mage_ImportExport Component: Dataflow Relates to Mage_Dataflow Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* composer Relates to composer.json phpstan phpcs php-cs-fixer PHPStorm phpunit ddev labels Aug 21, 2024
@sreichel
Copy link
Contributor Author

Wrong target ... closed.

@sreichel sreichel closed this Aug 21, 2024
@sreichel sreichel deleted the dep-rector branch August 21, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: ImportExport Relates to Mage_ImportExport Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: Sales Relates to Mage_Sales Component: Widget Relates to Mage_Widget composer Relates to composer.json ddev documentation environment php-cs-fixer phpcs phpstan PHPStorm phpunit Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sreichel