Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Signed-off-by: Mikalai Kutouski <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

* For wild VMs do only basic monitoring, skip extended info

Signed-off-by: Victor Hansson <[email protected]>

* Include field path for ALL form errors * Fix VNC validation Signed-off-by: Victor Hansson <[email protected]>

- allow newer ansible in provision - remove unsused files, roles - simplify opennebula-node-kvm - remove unsued ceonts files, - rename yaml -> yml - replace `include:` with `include_tasks:` - don't restart frr - bump Ceph version in HCI to Reef, adopt ceph-opennebula-mon

tinova · 2024-08-20T12:00:30Z

src/fireedge/src/server/utils/jwt.js

+ * @param {string} token - token JWT
+ * @returns {object} data JWT
+ */
+const jwtDecode = (token = '') => {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Avoid using == and === operators with sensitive data fields like passwords, api keys, tokens etc. as they are vulnerable to timing attack. Consider using crypto.timingSafeEqual or secure-compare for time-safe string comparison.

Learn more

tinova · 2024-08-20T12:00:32Z

src/fireedge/src/server/routes/api/oneflow/service/functions.js

+ */
+const getNodesService = (
+  user = '',
+  password = '',


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Avoid using == and === operators with sensitive data fields like passwords, api keys, tokens etc. as they are vulnerable to timing attack. Consider using crypto.timingSafeEqual or secure-compare for time-safe string comparison.

Learn more

tinova · 2024-08-20T12:00:52Z

src/im_mad/remotes/node-probes.d/pci.rb

@@ -90,6 +91,11 @@ def get_devices(filter = nil)
    end.flatten
 end

+def device_attr?(device, attribute)
+    addr = "0000:#{device[:bus]}:#{device[:slot]}.#{device[:function]}"
+    !`ls -l /sys/bus/pci/devices/#{addr}/ | grep #{attribute}`.empty?


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Detected a dangerous subshell execution vulnerability where user input is directly used in a shell command without proper sanitisation. This could allow an attacker to inject and execute arbitrary system commands, potentially leading to system compromise or data breach. To remediate, avoid using shell commands with user input when possible, or implement strict input validation and use shell escaping functions like Shellwords.escape(). If shell execution is necessary, consider using a allow list of allowed commands and arguments. Link to more info : https://guides.rubyonrails.org/security.html

Signed-off-by: dcarracedo <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

when attach nic after create a vm Signed-off-by: dcarracedo <[email protected]>

Fix is the same applied here: c9742ad3d798e3c (use to_s to prevent nil.upcase calls)

Signed-off-by: Neal Hansen <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

… cli (#3204)

* Schemas validated by online tool * Ambiguity errors not solved

* F #6505: Fix volatile disk backup and restore * F #6578: Skip backup of CDROM

Signed-off-by: dcarracedo <[email protected]>

(cherry picked from commit 08e7ff3)

Add a check before dereferencing the group roles pointer. (cherry picked from commit 48bab98)

Signed-off-by: Victor Hansson <[email protected]>

* Cleanup oned in case of initialization error * Fix monitoring after onemonitord restart. The code includes a "hook" point in case a driver is re-started so custom code can be executed. InformationManager sends the list of hosts and raft status in this case. * B #5801: Update error msg, in case of duplicated drivers

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

mkutouski and others added 7 commits August 6, 2024 11:19

B #6686: Provide full list of supported libvirt CPU features (#3196)

346686e

Signed-off-by: Mikalai Kutouski <[email protected]>

M #-: Correct SCSI typo (#3197)

3d527c3

Signed-off-by: Victor Hansson <[email protected]>

F #6684: Add firmware options fetching (#3198)

6d60b43

Signed-off-by: Victor Hansson <[email protected]>

M #-: Fix error in wild VM monitoring (#3199)

f7737bc

* For wild VMs do only basic monitoring, skip extended info

M #-: Fix 'getHostsAdmin' server handler (#3200)

7d09405

Signed-off-by: Victor Hansson <[email protected]>

F #6662: Fix form validation (#3201)

a7da395

* Include field path for ALL form errors * Fix VNC validation Signed-off-by: Victor Hansson <[email protected]>

tinova reviewed Aug 20, 2024

View reviewed changes

dcarracedo and others added 20 commits August 23, 2024 13:08

M #-: Schedule actions tab on services. Perform action on role. (#3206)

5dff938

Signed-off-by: dcarracedo <[email protected]>

M #-: Install OpenNebula 6.10 in provision (#3195)

5d6b857

Co-authored-by: Tino Vázquez <[email protected]>

F #6676: Add X509 login mechanism for FireEdge (#3211)

875fe29

M #-: Disable network mode auto (#3209)

1fd2e22

when attach nic after create a vm Signed-off-by: dcarracedo <[email protected]>

B ##6665: Fix missing CLEANUP_MEMORY_ON_STOP for KVM migrations

4c7f6dc

Fix is the same applied here: c9742ad3d798e3c (use to_s to prevent nil.upcase calls)

B #6701: fix total_mb type in s3/monitor (#3213)

02e0fce

Signed-off-by: Neal Hansen <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

M #-: Bump version 6.99.0

0491d23

B #6058: Add missing content-type on oneflow-template and oneflow…

d8d1409

… cli (#3204)

M #-: Fix *.xsd (#3205)

cd9eb49

* Schemas validated by online tool * Ambiguity errors not solved

B #6694: Check error code of read function (#3208)

7fe28f2

B #6607: Fix size of restored disk from backup (#3210)

420162d

B #6505: Fix volatile disk backup (#3212)

c8c66b1

* F #6505: Fix volatile disk backup and restore * F #6578: Skip backup of CDROM

F #6524: Check free space on backup DS (#3214)

ccc8ccf

B #6707: Boolean default values on user inputs (#3215)

4a1abef

Signed-off-by: dcarracedo <[email protected]>

B #6710: (FSunstone) keep_me_logged variable fix

34ccd72

(cherry picked from commit 08e7ff3)

B #6692: Check VMGroupRole in Inter-role Anti-affinity rules

1607b4a

Add a check before dereferencing the group roles pointer. (cherry picked from commit 48bab98)

B #6710: Fix config typo (#3217)

fd4956e

Signed-off-by: Victor Hansson <[email protected]>

M #-: Fix spelling in onevm command help

822581a

B #6532: Sunstone fix backup volatile disk checkmark (#3216)

b2ab5b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese commented Nov 29, 2021 •

edited

Loading

tinova Apr 25, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Aug 20, 2024

tinova Aug 20, 2024

tinova Aug 20, 2024

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading