-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PROJ 5.1 API #1218
Use PROJ 5.1 API #1218
Conversation
Please, base you work on I'm not sure how fast we actually want to remove compatibility with PROJ 4.9. Ubuntu 18.04 will be LTS at least until 2020. I don't know when Debian 9 will be replaced. |
I brought the proj-5 branch up-to-date with dev. Now it looks like a mess. Maybe it needs a different branch and/or a new pull request. Also, checks are failing due to PROJ 5.0's |
Understood. Seeing the component version matrix, you are juggling a great number of dependencies. |
I think you could do the following now:
This should cherry-pick your new commits (which are after ed39289) on top of dev. I'm about to skip PROJ 5 for PROJ 6 in Superbuild if it works for Android, too. However, I'm struggling with the GDAL update to 2.4 which I want to do at the same time. Maybe it is easier to wait a few days. |
Changing the PR's base branch in GitHub from |
On the PROJ mailing was a thread about porting to PROJ 6. Some takeaways:
|
Cherry-picked from GH-1218, and edited. Does not compile with PROJ 4.9!
Cherry-picked from GH-1218, and edited.
Cherry-picked from GH-1218, and edited. Does not compile with PROJ 4.9!
25ccda8
to
025ff81
Compare
5bdeb20
to
a96bc58
Compare
This is now entirely replaced by #1341. Thanks for the excellent starting point. It even helped find bugs in PROJ. |
This updates Georeferencing to use the PROJ 5.1 API. I'm initiating this PR to show the status of this work. I've tested it on Linux, and will test more thoroughly including on Android.
The
pj_strerrno
function is replaced withproj_errno_string
, which was introduced in 5.1.Search uses the environment's
PROJ_LIB
, as suggested by @dg0yt.