Use PROJ 6 API for Georeferencing #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing the calculated longitude, we must *multiply* the angular error with a factor derived from the latitude, and we must pass the latitude in *radians* to the cos function. For the "LVermGeo RLP Pruem GK2" dataset, the error is slightly larger than expected, so we need to increase the tolerance as well.
All tests pass with PROJ 4.9.3 (Ubuntu 18.04). Task: GH-1325 (Geographic offset in CH1903+/LV95 with PROJ 6)
dg0yt
force-pushed
the
georeferencing
branch
3 times, most recently
from
25ccda8
to
025ff81
Compare
...instead of 'PROJ.4'. User interface and user documentation need to be handled later. The file format usage of 'PROJ.4 as an identifier will need more thought: The legacy specs need to be supported for handling existing maps, but PROJ now encourages specifying CRS as AUTHORITY:CODE or by WKT strings instead of PROJ strings (cf. https://proj.org/development/migration.html)
This matches the minimum version documented in INSTALL.md.
We can encapsulate the PROJ lib access and memory management in a simple data type. This will facilitate providing a second implementation for the new PROJ API.
The Android file handler is supported only for the new API now, because we are not going to ship an old PROJ version again.
Closed
dg0yt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.