Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Chinese localization for web config #1035

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Adding Chinese localization for web config #1035

merged 5 commits into from
Jun 17, 2024

Conversation

rebornsick
Copy link
Contributor

Supplement and improve Chinese localization.

@SavageCore SavageCore marked this pull request as draft June 4, 2024 11:22
@SavageCore
Copy link
Member

Thanks! I've marked this as Draft for now until we land #1040

- Adding Chinese translation for Rotary Encoders addon
- Polishing Chinese translations
- Changed order of "Pin LED" to "LED Pin"
- Removed labels that are not in use
@rebornsick
Copy link
Contributor Author

I removed 4 labels under AddonsConfig.jsx that seems not in use, and changed the order of "Pin LED" to "LED Pin".

@rebornsick rebornsick marked this pull request as ready for review June 17, 2024 08:28
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We are fine with the language change "Turbo Pin LED -> Turbo LED Pin" as it specifies the subject and then "Pin" which is probably much easier to translate.

@arntsonl arntsonl merged commit 5ec189c into OpenStickCommunity:main Jun 17, 2024
41 checks passed
@rebornsick rebornsick deleted the zh-CN_localization branch June 18, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants