only trigger a hotkey action once per press #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working on 4-way joystick mode toggling in another branch, it was random whether or not I "landed" on set or unset. I identified this as the hotkey code not properly tracking lastAction. before this change, while a hotkey was held, the action would be applied every time hotkey() was called, e.g. every millisecond, because lastAction was always NONE. this was only checked on the Y-axis toggle, but is now checked on all hotkey actions, as it also allows us from calling save() unnecessarily. following this change I no longer experience the ambiguity on where I "land" for hotkeys that toggle a setting
bsstephan
force-pushed
the
improve-hotkey-processing
branch
from
afdef0c
to
4466411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on 4-way joystick mode toggling in another branch, it was random whether or not I "landed" on set or unset. I identified this as the hotkey code not properly tracking lastAction.
before this change, while a hotkey was held, the action would be applied every time hotkey() was called, e.g. every millisecond, because lastAction was always NONE. this was only checked on the Y-axis toggle, but is now checked on all hotkey actions, as it also allows us from calling save() unnecessarily.
following this change I no longer experience the ambiguity on where I "land" for hotkeys that toggle a setting