Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only trigger a hotkey action once per press #325

Merged
merged 1 commit into from
Jun 14, 2023
Merged

only trigger a hotkey action once per press #325

merged 1 commit into from
Jun 14, 2023

Commits on Jun 13, 2023

  1. only trigger a hotkey action once per press 

    working on 4-way joystick mode toggling in another branch, it was random
whether or not I "landed" on set or unset. I identified this as the
hotkey code not properly tracking lastAction.

before this change, while a hotkey was held, the action would be applied
every time hotkey() was called, e.g. every millisecond, because
lastAction was always NONE. this was only checked on the Y-axis toggle,
but is now checked on all hotkey actions, as it also allows us from
calling save() unnecessarily.

following this change I no longer experience the ambiguity on where I
"land" for hotkeys that toggle a setting
    @bsstephan
    bsstephan committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4466411 View commit details
    Browse the repository at this point in the history