Fix Reflex CTRL SNES Pinout, Rename Reflex Encode, Add Reflex Encode V2 #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 216f71d.
TheTrainGoes
requested changes
Oct 15, 2023
There was a problem hiding this comment.
Hey @misteraddons ,
Looks mostly good. Line 13 in the v1 and v2 does not need to specify all of these.
You can take a look here if want to foce a boot to a specific mode:
https://github.com/OpenStickCommunity/GP2040-CE/blob/0589f43e704d80b4bd81a19fc2dd35b88b13d45e/configs/RP2040AdvancedBreakoutBoardUSBPassthrough/BoardConfig.h#L66C1-L66C42
Otherwise you can leave as is and it will default to Xinput.
|
Awesome, I just pushed an update. Thanks for the tip!
…On Sun, Oct 15, 2023 at 3:03 PM TheTrain ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @misteraddons <https://github.com/misteraddons> ,
Looks mostly good. Line 13 in the v1 and v2 does not need to specify all
of these.
You can take a look here if want to foce a boot to a specific mode:
https://github.com/OpenStickCommunity/GP2040-CE/blob/0589f43e704d80b4bd81a19fc2dd35b88b13d45e/configs/RP2040AdvancedBreakoutBoardUSBPassthrough/BoardConfig.h#L66C1-L66C42
Otherwise you can leave as is and it will default to Xinput.
—
Reply to this email directly, view it on GitHub
<#576 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMFWWHWTZX656P5YKROH46LX7RFRHANCNFSM6AAAAAA6BG2F7Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
added 2 commits
October 15, 2023 15:11
arntsonl
approved these changes
Oct 18, 2023
jack2game
added a commit
to jack2game/GP2040-CE
that referenced
this pull request
Oct 20, 2023
* Change target button for DirectInput/PS3 Mode in documentation (OpenStickCommunity#570) Change target button for DirectInput/PS3 Mode Currently both Xinput and DirectInput/PS3 Modes are labeled as being invoked by B2. This is to change the DirectInput/PS3 button to be B3. * Update analog trigger mode to include digital state (OpenStickCommunity#571) * Allow digital input state and analog value state to co-exist for triggers when Gamepad.hasAnalogTriggers is true. Added analog trigger check for keyboard host to avoid potential issues. * Fixed issue where Wii analog trigger options could not be changed to None * Change PS4 analog trigger state back to previous behavior. Report already handles both button and trigger values. XInput does not support both. * More Macro fixes (OpenStickCommunity#574) * Add Macro Board LED enabled field * Add Macro addon enable indicator in OLED * Enable Macro Lock in Focus Mode addon by default * Small cleanup * Fix default On-Board LED enable issue (OpenStickCommunity#573) * Add missing On-Board LED initialization entry * Add board LED define in default BoardConfig * Fix doc typo (OpenStickCommunity#579) * Fix Reflex CTRL SNES Pinout, Rename Reflex Encode, Add Reflex Encode V2 (OpenStickCommunity#576) * Update Reflex Encode Fighting Board config * Fix onboard LED * Reflex CTRL SNES config * Update cmake.yml * Update cmake.yml * Fix cmake.yml * Add ReflexEncodeV2 * Rename "ReflexEncoder" to "ReflexEncodeV1" and add cmake.yml entries * MiSTercade V2 Board * Just build mistercade * Add 15th button * Update BoardConfig.h * Define onboard LED GPIO * Update cmake.yml * Update BoardConfig.h * Rebase * Enable onboard LED * Fix ON_BOARD_LED * Update cmake.yml * Update Board Configs * Update usage.md * Sync with main repo * Update ReflexEncodeV2 Readme * Revert "Update ReflexEncodeV2 Readme" This reverts commit 216f71d. * Update ReflexEncodeV2 Readme * Update EncodeV1 and EncodeV2 board configs * Typo * Change ON_BOARD_LED function --------- Co-authored-by: Robot <[email protected]> Co-authored-by: TheTrain <[email protected]> * Adds config for the Rana Tadpole (OpenStickCommunity#580) * resolve issue 578 (OpenStickCommunity#581) * resolve issue 578 Fixes issue 578 by adding a check for input mode and applying a bit shift to the mid value present in the 8-bit modes before the shift down to 8-bit. The issue was from the generic gamepad 16-bit mid value being 0x7FFFF shifting down to 0x7F which is not true center for input modes, as they expect 0x80 to be center. * PS4 macros Separate PS4 and HID macros, add them to their relevant USB reports. * fix joystick midpoints (OpenStickCommunity#582) * resolve issue 578 Fixes issue 578 by adding a check for input mode and applying a bit shift to the mid value present in the 8-bit modes before the shift down to 8-bit. The issue was from the generic gamepad 16-bit mid value being 0x7FFFF shifting down to 0x7F which is not true center for input modes, as they expect 0x80 to be center. * PS4 macros Separate PS4 and HID macros, add them to their relevant USB reports. * fix joystick midpoint Create helper function and add fix to missed areas. * Update GamepadState.h * Tilt adjustments (OpenStickCommunity#584) * Mark Tilt addon as unavailable if pins are not defined when enabled. * Fix indent on tilt. * Tilt state refactor and analog mid adjustments (OpenStickCommunity#585) * Mark Tilt addon as unavailable if pins are not defined when enabled. * Fix indent on tilt. * Incorporates PR OpenStickCommunity#577 and analog mid changes from OpenStickCommunity#582 * Tilt state refactor * Allow tilt dpad mode to work with existing dpad inputs * Updating All Gamepad MID Macros to use our mid-function (OpenStickCommunity#583) * Replacing all the mid macros * Updating everything to mid * Update tilt.cpp * Fixes Macro type Press and Loop issue (OpenStickCommunity#587) * Fix looping macro first input line duration error * Fix Press macro interruptible check with debounce * Remove onboard LED pin definition from devices without an onboard LED (OpenStickCommunity#590) --------- Co-authored-by: outphase <[email protected]> Co-authored-by: Mike Parks <[email protected]> Co-authored-by: deeebug <[email protected]> Co-authored-by: AkariiinMKII <[email protected]> Co-authored-by: misteraddons <[email protected]> Co-authored-by: Robot <[email protected]> Co-authored-by: TheTrain <[email protected]> Co-authored-by: NickGuyver <[email protected]> Co-authored-by: Luke Arntson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.