Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add site_id #47

Merged
merged 1 commit into from
Sep 12, 2023
Merged

add site_id #47

merged 1 commit into from
Sep 12, 2023

Conversation

JarbasAl
Copy link
Member

initial PR adding the field for site_id

skills can then consume this info, to be provided via mycroft.conf/backend/voice_sat ....

initial PR adding the field for site_id

skills can then consume this info, to be provided via mycroft.conf/backend/voice_sat ....
@JarbasAl JarbasAl added the enhancement New feature or request label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.04% 🎉

Comparison is base (1ed65b5) 53.41% compared to head (aa04ebf) 53.45%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #47      +/-   ##
==========================================
+ Coverage   53.41%   53.45%   +0.04%     
==========================================
  Files          14       14              
  Lines        1084     1085       +1     
==========================================
+ Hits          579      580       +1     
  Misses        505      505              
Files Changed Coverage Δ
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/session.py 54.71% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 2e194b9 into dev Sep 12, 2023
7 checks passed
@JarbasAl JarbasAl deleted the add-site_id branch September 12, 2023 14:31
JarbasAl added a commit to JarbasHiveMind/HiveMind-core that referenced this pull request Sep 12, 2023
JarbasAl added a commit to JarbasHiveMind/HiveMind-core that referenced this pull request Sep 12, 2023
JarbasAl added a commit to JarbasHiveMind/hivemind-websocket-client that referenced this pull request Sep 12, 2023
JarbasAl added a commit to JarbasHiveMind/HiveMind-voice-sat that referenced this pull request Sep 12, 2023
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant