Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/site_id_seriallization #48

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

JarbasAl
Copy link
Member

site_id being dropped during serialize/deserialize operations

missed in #47

site_id being dropped during serialize/deserialize operations
@JarbasAl JarbasAl added the bug Something isn't working label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.04% 🎉

Comparison is base (2e194b9) 53.45% compared to head (7a98461) 53.49%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #48      +/-   ##
==========================================
+ Coverage   53.45%   53.49%   +0.04%     
==========================================
  Files          14       14              
  Lines        1085     1086       +1     
==========================================
+ Hits          580      581       +1     
  Misses        505      505              
Files Changed Coverage Δ
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/session.py 54.87% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit b585d2c into dev Sep 14, 2023
7 checks passed
@JarbasAl JarbasAl deleted the hotfix/site_id_seriallization branch September 14, 2023 19:38
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant