Avoid showing variable name on prompt message if not available (#1224)

* Avoid showing variable name on prompt if empty

* Set a parameter name if missing

* Add more tests

packages/cli/src/commands/init.ts

@@ -52,15 +52,15 @@ function getCommandProps(): InquirerQuestions {
     name: {
       message: 'Welcome to the OpenZeppelin SDK! Choose a name for your project',
       type: 'input',
-      validate: notEmpty
+      validate: notEmpty,
     },
     version: {
       message: 'Initial project version',
       type: 'input',
       validate: input => {
         if (semver.parse(input)) return true;
         return `Invalid semantic version: ${input}`;
-      }
+      },
     },
   };
 }

packages/cli/src/models/compiler/solidity/SolidityContractsCompiler.ts

@@ -174,9 +174,7 @@ class SolidityContractsCompiler {
     const output = solcOutput.contracts[fileName][contractName];
     const source = solcOutput.sources[fileName];
     fileName = path.basename(fileName);
-    const contract = this.contracts.find(
-      aContract => aContract.fileName === fileName,
-    );
+    const contract = this.contracts.find(aContract => aContract.fileName === fileName);
 
     return {
       fileName,

packages/cli/src/models/dependency/Dependency.ts

@@ -57,7 +57,9 @@ export default class Dependency {
     const hasDependenciesForDeploy = dependencies.find(
       (depNameAndVersion): any => {
         const dependency = Dependency.fromNameWithVersion(depNameAndVersion);
-        return !(dependency.isDeployedOnNetwork(network) || networkFile.dependencyHasMatchingCustomDeploy(dependency.name));
+        return !(
+          dependency.isDeployedOnNetwork(network) || networkFile.dependencyHasMatchingCustomDeploy(dependency.name)
+        );
       },
     );
 

packages/cli/src/models/local/KitController.ts

@@ -13,7 +13,12 @@ import child from '../../utils/child';
 const simpleGit = patch('simple-git/promise');
 
 export default class KitController {
-  public async unpack(url: string, branchName: string = 'stable', workingDirPath: string = '', config: KitFile): Promise<void | never> {
+  public async unpack(
+    url: string,
+    branchName: string = 'stable',
+    workingDirPath: string = '',
+    config: KitFile,
+  ): Promise<void | never> {
     if (!url) throw Error('A url must be provided.');
     if (!config) throw Error('A config must be provided.');
 
@@ -45,7 +50,7 @@ export default class KitController {
       // always delete .git folder
       await remove(path.join(workingDirPath, '.git'));
       // run kit commands like `npm install`
-      await exec(config.hooks['post-unpack'], { maxBuffer: 1024 * 1024 * 100});
+      await exec(config.hooks['post-unpack'], { maxBuffer: 1024 * 1024 * 100 });
       Loggy.succeed('unpack-kit', 'Kit downloaded and unpacked');
 
       Loggy.noSpin(__filename, 'unpack', 'unpack-succeeded', `The kit is ready to use. \n${config.message}`);

packages/cli/src/prompts/method-params.ts

@@ -59,7 +59,7 @@ function getCommandProps(
     return {
       ...accum,
       [arg.name]: {
-        message: `${arg.name} (${arg.type}):`,
+        message: arg.name ? `${arg.name} (${arg.type}):` : `(${arg.type}):`,
         type: 'input',
         when: () => !methodArgs || !methodArgs[index],
         validate: input => {

packages/cli/src/prompts/prompt.ts

@@ -172,7 +172,7 @@ export function methodsList(
   return contractMethods(contractFullName, constant, projectFile)
     .map(({ name, hasInitializer, inputs, selector }) => {
       const initializable = hasInitializer ? '* ' : '';
-      const args = inputs.map(({ name: inputName, type }) => `${inputName}: ${type}`);
+      const args = inputs.map(({ name: inputName, type }) => (inputName ? `${inputName}: ${type}` : type));
       const label = `${initializable}${name}(${args.join(', ')})`;
 
       return { name: label, value: { name, selector } };
@@ -198,7 +198,13 @@ export function argsList(
   const method = contractMethods(contractFullName, constant, projectFile).find(
     ({ name, selector }): any => selector === methodIdentifier || name === methodIdentifier,
   );
-  return method ? method.inputs : [];
+
+  if (method) {
+    return method.inputs.map((input, index) => {
+      return input.name ? input : { ...input, name: `#${index}` };
+    });
+  }
+  return [];
 }
 
 function contractMethods(

packages/cli/src/prompts/validators.ts

@@ -1,4 +1,4 @@
 export function notEmpty(input) {
   if (input && input.length > 0) return true;
-  return "Please enter a non-empty value";
-}
+  return 'Please enter a non-empty value';
+}

packages/cli/test/mocks/mock-stdlib/contracts/GreeterImpl.sol

@@ -4,6 +4,8 @@ import "./GreeterLib.sol";
 
 contract GreeterImpl {
   using GreeterLib for string;
+
+  mapping(uint256 => string) public greetings;
   event Greeting(string greeting);
 
   function greet(string memory who) public {