Avoid showing variable name on prompt message if not available #1224

jbcarpanelli · 2019-09-09T22:28:08Z

Fixes #1209. This PR fixes oz call, oz send-tx, oz create and oz upgrade interactive method and method arguments prompts when a contract has:

A public mapping variable defined (and thus a getter function associated)
A function that receives parameters without name.

In both cases, we are now showing the function definition without the variable name and a #0, #1, #2, ..., #n for each parameter without a name:

ylv-io

This is a proper pull request 🚢

jbcarpanelli added 3 commits September 9, 2019 19:25

Avoid showing variable name on prompt if empty

e45003f

Set a parameter name if missing

14a83b5

Add more tests

1a145aa

jbcarpanelli requested a review from ylv-io September 11, 2019 17:33

jbcarpanelli marked this pull request as ready for review September 11, 2019 17:36

jbcarpanelli changed the title ~~Avoid showing variable name on prompt message if no variable name is available~~ Avoid showing variable name on prompt message if not available Sep 11, 2019

ylv-io approved these changes Sep 11, 2019

View reviewed changes

ylv-io merged commit 269f097 into master Sep 11, 2019

jbcarpanelli deleted the fix/support-reading-from-public-mappings branch September 12, 2019 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid showing variable name on prompt message if not available #1224

Avoid showing variable name on prompt message if not available #1224

jbcarpanelli commented Sep 9, 2019 •

edited

Loading

ylv-io left a comment

Avoid showing variable name on prompt message if not available #1224

Avoid showing variable name on prompt message if not available #1224

Conversation

jbcarpanelli commented Sep 9, 2019 • edited Loading

ylv-io left a comment

Choose a reason for hiding this comment

jbcarpanelli commented Sep 9, 2019 •

edited

Loading