Bump web3.js to 1.2.2 #1277
Bump web3.js to 1.2.2 #1277
Conversation
|
It was my understanding that the latest web3 version comes with typings that work properly - if that's the case, shouldn't we also drop the dependency on @types/web3? |
|
@nventuro CI is finally green. Can I ask for a re-review? |
| <<: *defaults | ||
| steps: | ||
| - test: | ||
| workspace: examples/lib-complex |
There was a problem hiding this comment.
I noticed all of lib-complex, including the CI is setup, is gone. Is this related to the web3 upgrade?
There was a problem hiding this comment.
Yep, lib-complex was using outdated versions of everything - it even pulled zos-lib and [email protected]. I spent a few hours trying to upgrade it, and eventually decided to cut it.
| "web3": "1.2.1", | ||
| "web3-utils": "1.2.0" | ||
| "web3": "1.2.2", | ||
| "web3-eth": "1.2.2", |
There was a problem hiding this comment.
Are these being added so that they are pinned? They seem to be already pinned on the web3 package itself.
There was a problem hiding this comment.
This is what yarn failed to properly hoist. On a clean install, I ended up with web3 1.2.2, web3-eth 1.2.2, but web3-eth-contract 1.2.1. We have a transitive dependency to web3 1.2.1, which is installed within the package that requires it, but that's not the case for web3-eth-contract.
There was a problem hiding this comment.
Ah, I see. It'd be great if we were able to document this here. Shame Crockford decided to disallow comments
Co-Authored-By: Nicolás Venturo <[email protected]>
* Bump web3 to 1.2.2 * Remove @types/web3 * Patch typing of web3.eth.getStorageAt * Fix Web3 contract typings for v1.2.2 * Remove outdated lib-complex * Use yarn instead of lerna bootstrap on integration test * Clean up root yarn lock * Remove lib-complex example from CI * CI cache bust * Pin dependencies on web3-eth-contract * Update required CI checks for mergify * Update packages/lib/src/artifacts/ZWeb3.ts Co-Authored-By: Nicolás Venturo <[email protected]> (cherry picked from commit 28dbea4)
No description provided.