Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Bump web3.js to 1.2.2 #1277

Merged
merged 12 commits into from
Nov 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ commands:
steps:
- checkout
- restore_cache:
key: dependency-cache-v4-{{ checksum "yarn.lock" }}
key: dependency-cache-v5-{{ checksum "yarn.lock" }}
nventuro marked this conversation as resolved.
Show resolved Hide resolved
- attach_workspace:
at: ~/openzeppelin
- when:
condition: << parameters.run-yarn >>
steps:
- restore_cache:
key: yarn-cache-v6-
key: yarn-cache-v7-
- run:
command: yarn
working_directory: "~/openzeppelin/<< parameters.workspace >>"
Expand All @@ -55,19 +55,19 @@ jobs:
- checkout
- restore_cache:
keys:
- dependency-cache-v4-{{ checksum "yarn.lock" }}
- yarn-cache-v6-
- dependency-cache-v5-{{ checksum "yarn.lock" }}
- yarn-cache-v7-
- run:
name: Install dependencies and build
command: yarn
- save_cache:
key: dependency-cache-v4-{{ checksum "yarn.lock" }}
key: dependency-cache-v5-{{ checksum "yarn.lock" }}
paths:
- node_modules
- packages/cli/node_modules
- packages/lib/node_modules
- save_cache:
key: yarn-cache-v6-{{ checksum "yarn.lock" }}
key: yarn-cache-v7-{{ checksum "yarn.lock" }}
paths:
- ~/.cache/yarn/v6
- persist_to_workspace:
Expand Down Expand Up @@ -97,13 +97,6 @@ jobs:
workspace: examples/lib-simple
run-yarn: true

example-lib-complex:
<<: *defaults
steps:
- test:
workspace: examples/lib-complex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed all of lib-complex, including the CI is setup, is gone. Is this related to the web3 upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, lib-complex was using outdated versions of everything - it even pulled zos-lib and [email protected]. I spent a few hours trying to upgrade it, and eventually decided to cut it.

run-yarn: true

example-create-instances-from-solidity:
<<: *defaults
steps:
Expand Down Expand Up @@ -164,8 +157,6 @@ workflows:
requires: [setup]
- example-lib-simple:
requires: [test-lib]
- example-lib-complex:
requires: [test-lib]
- example-create-instances-from-solidity:
requires: [test-lib, test-cli]
- example-cli-create2:
Expand Down
4 changes: 3 additions & 1 deletion .mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ pull_request_rules:
- 'status-success="ci/circleci: test-lib"'
- 'status-success="ci/circleci: example-create-instances-from-solidity"'
- 'status-success="ci/circleci: example-lib-simple"'
- 'status-success="ci/circleci: example-lib-complex"'
- 'status-success="ci/circleci: example-cli-create2"'
- 'status-success="ci/circleci: example-first-project"'
- 'status-success="ci/circleci: integration-cli-geth"'
- 'status-success="ci/circleci: integration-cli-hdwallet"'
- 'status-success="ci/circleci: integration-cli-kits"'
- name: delete head branch after merge
conditions:
- merged
Expand Down
2 changes: 1 addition & 1 deletion examples/cli-create2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@openzeppelin/cli": "^2.6.0-rc.0",
"@openzeppelin/upgrades": "^2.6.0-rc.0",
"web3": "1.2.1"
"web3": "1.2.2"
},
"devDependencies": {
"chai": "^4.2.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/first-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"test": "scripts/test-ci.sh"
},
"dependencies": {
"web3": "1.2.1"
"web3": "1.2.2"
},
"devDependencies": {
"@openzeppelin/cli": "^2.6.0-rc.0",
Expand Down
10 changes: 0 additions & 10 deletions examples/lib-complex/.babelrc

This file was deleted.

3 changes: 0 additions & 3 deletions examples/lib-complex/.gitignore

This file was deleted.

7 changes: 0 additions & 7 deletions examples/lib-complex/README.md

This file was deleted.

28 changes: 0 additions & 28 deletions examples/lib-complex/contracts/DonationsV1.sol

This file was deleted.

26 changes: 0 additions & 26 deletions examples/lib-complex/contracts/DonationsV2.sol

This file was deleted.

96 changes: 0 additions & 96 deletions examples/lib-complex/index.js

This file was deleted.

2 changes: 0 additions & 2 deletions examples/lib-complex/migrations/notes.md

This file was deleted.

38 changes: 0 additions & 38 deletions examples/lib-complex/package.json

This file was deleted.

74 changes: 0 additions & 74 deletions examples/lib-complex/test/App.test.js

This file was deleted.

Loading