Skip to content

Commit

Permalink
feat #1112 (carousel pause button): fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
MewenLeHo authored and julien-deramond committed Apr 19, 2022
1 parent 4fd6b3c commit 2b91136
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion js/tests/unit/carousel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ describe('Carousel', () => {
const carouselEl = fixtureEl.querySelector('#myCarousel')
const carousel = new Carousel(carouselEl)

spyOn(carousel, 'pause').and.callThrough()
spyOn(carousel, 'pause')

const mouseOverEvent = createEvent('mouseover')
carouselEl.dispatchEvent(mouseOverEvent)
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/5.1/components/carousel.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Carousel progress indicator is paused under multiple conditions:
### With pause/play button

Adding a pause and play button is recommended to setup an accessible carousel.
This `button` must immediately follow your carousel and have the customs `data-bs-control="play-button"` attribute. In addition, it must also have a `data-bs-target` attribute that matches the `id` of the `.carousel` element.
This `button` must immediately follow your carousel and have the custom `data-bs-control="play-button"` attribute. In addition, it must also have a `data-bs-target` attribute that matches the `id` of the `.carousel` element.

{{< example >}}
<div id="carouselExamplePause" class="carousel slide" data-bs-ride="carousel">
Expand Down

0 comments on commit 2b91136

Please sign in to comment.