Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a pause button for Carousels #1112

Closed
Tracked by #901
julien-deramond opened this issue Feb 23, 2022 · 0 comments · Fixed by #1146
Closed
Tracked by #901

Provide a pause button for Carousels #1112

julien-deramond opened this issue Feb 23, 2022 · 0 comments · Fixed by #1146
Assignees
@MewenLeHo
Labels
accessibility back-from-v4 feature v5

Comments

@julien-deramond
Copy link
Member

julien-deramond commented Feb 23, 2022 •
edited
Loading

An example of a pause button was provided in v4 for the carousels (see https://boosted.orange.com/docs/4.6/components/carousel/#with-controls).

It is required for a11y purpose.

This example must be reintegrated in the version 5 of Boosted.

This issue maybe requires to specify with the designers where this pause button should be displayed. It could be integrated within the carousel and not necessarily outside the carousel.

If a JavaScript example must be present in the doc: transform the jQuery version of the v4 in JS in this v5.
@julien-deramond julien-deramond mentioned this issue Feb 23, 2022
Closed
@MewenLeHo MewenLeHo self-assigned this Mar 7, 2022
MewenLeHo added a commit that referenced this issue Mar 10, 2022
@MewenLeHo
feat #1112 (carousel pause button): basic setup
11da3d8
MewenLeHo added a commit that referenced this issue Mar 10, 2022
@MewenLeHo
feat #1112 (carousel pause button): basic setup
47a3cb9
MewenLeHo added a commit that referenced this issue Mar 11, 2022
@MewenLeHo
feat #1112 (carousel pause button): add accessibility attributes
6e576ae
MewenLeHo added a commit that referenced this issue Mar 11, 2022
@MewenLeHo
feat #1112 (carousel pause button): refactoring, add icons and fix ac…
bac84a0 
…cessibility
MewenLeHo added a commit that referenced this issue Mar 11, 2022
@MewenLeHo
feat #1112 (carousel pause button): minor JS fix
715cc8f
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): add new button / hover event inte…
ef36c8a 
…raction
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix interaction between two pause…
d9e7c27 
… events
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): minor fix
2272523
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix bundlewatch
577d087
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): basic setup
5450994
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): add accessibility attributes
4498b36
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): refactoring, add icons and fix ac…
e3deaca 
…cessibility
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): minor JS fix
8fdec40
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): add new button / hover event inte…
8f93ccd 
…raction
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix interaction between two pause…
8f962ca 
… events
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): minor fix
5dde7a5
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix bundlewatch
05a2203
MewenLeHo added a commit that referenced this issue Mar 14, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix bundlewatch
7aa7356
MewenLeHo added a commit that referenced this issue Mar 15, 2022
@MewenLeHo
feat #1112 (carousel pause button): add documentation
81971f2
MewenLeHo added a commit that referenced this issue Mar 15, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix accessibility
3149b7a
MewenLeHo added a commit that referenced this issue Mar 15, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix accessibility
81062a5
MewenLeHo added a commit that referenced this issue Mar 15, 2022
@MewenLeHo
feat #1112 (carousel pause button): refactoring and minor accessibili…
5f36091 
…ty fix
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): minor JS fix
fd6d39f
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add new button / hover event inte…
d62d3b5 
…raction
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fix interaction between two pause…
8241b92 
… events
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): minor fix
79e8154
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add documentation
e792f4e
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fix accessibility
198a301
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fix accessibility
ea09165
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): refactoring and minor accessibili…
f05b294 
…ty fix
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): js refactoring to fix tests
3af2edc
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): refactoring js
0e930c8
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add first set of unit tests
a1aa943
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fixes after review
1cc6bc8
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fixes after review
c29fefc
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fixes after review
4fd6b3c
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fixes after review
2b91136
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fix after rebase
b09bc4b
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add a way to translate play and p…
029f3c5 
…ause text using custom data-bs-* attribute
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fixes after review
70859a4
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add doc and unit test
5a486d2
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): fix jobs
4edb5c5
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): add default texts and unit tests
38baf7e
julien-deramond pushed a commit that referenced this issue Apr 19, 2022
@MewenLeHo @julien-deramond
feat #1112 (carousel pause button): basic setup
31e3fce
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix after review
4038734
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix tests
c9354f9
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): basic setup
778cc0a
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix after review
0ed2ec6
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix tests
2c06277
MewenLeHo added a commit that referenced this issue Apr 19, 2022
@MewenLeHo
feat #1112 (carousel pause button): fix bundlewatch
f3bcc67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MewenLeHo MewenLeHo

Labels
accessibility back-from-v4 feature v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide a pause button for Carousels Orange-OpenSource/Orange-Boosted-Bootstrap
2 participants
@julien-deramond @MewenLeHo