Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry for dependency management #411

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Use poetry for dependency management #411

merged 4 commits into from
Mar 3, 2024

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Feb 26, 2024

Description of Changes

Fixes #374. Use poetry for dependency management (Borrowing heavily from lucyparsons#893)

Notes for Deployment

  • With this change, we won't automatically re-build scss files when they are updated anymore. (The nodejs build is completely done in a separate Docker build stage now) I don't think it's a big deal since we don't regularly update our styles.
  • I did have to upgrade our pandas version since we were using a very old version. Please check that the data-mungers still work!

Screenshots (if appropriate)

N/A

Tests and linting

Ran unit tests and checked that development and prod instances run

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@sea-kelp sea-kelp requested a review from a team as a code owner February 26, 2024 06:17
@sea-kelp
Copy link
Collaborator Author

Also tagging @michplunkett in case you want to copy this for upstream

@sea-kelp sea-kelp mentioned this pull request Feb 27, 2024
3 tasks
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! It's nice to get rid of the entrypoint, and the multi-stage build makes a ton of sense. The pandas changes should be fine, as we're not doing anything too out there and the API hasn't changed significantly.

Comment on lines +1 to +7
# node layer to build static assets
FROM node:16 AS nodejs
WORKDIR /usr/src/app/
COPY package.json yarn.lock ./
RUN yarn install
COPY OpenOversight/app/static/ OpenOversight/app/static/
RUN yarn build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!!

@AetherUnbound AetherUnbound merged commit 8e5bc8d into main Mar 3, 2024
2 checks passed
@AetherUnbound AetherUnbound deleted the 374/use-poetry branch March 3, 2024 02:47
@michplunkett
Copy link

I'm torn between updating the main repository to Poetry or doing the new shiny thing and migrating it to uv. Poetry does make the most sense, but I am very drawn to the new shiny thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider using poetry or pipfile for dependency management
3 participants