-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poetry for dependency management #411
Conversation
Also tagging @michplunkett in case you want to copy this for upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! It's nice to get rid of the entrypoint, and the multi-stage build makes a ton of sense. The pandas changes should be fine, as we're not doing anything too out there and the API hasn't changed significantly.
# node layer to build static assets | ||
FROM node:16 AS nodejs | ||
WORKDIR /usr/src/app/ | ||
COPY package.json yarn.lock ./ | ||
RUN yarn install | ||
COPY OpenOversight/app/static/ OpenOversight/app/static/ | ||
RUN yarn build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!!
I'm torn between updating the main repository to Poetry or doing the new shiny thing and migrating it to uv. Poetry does make the most sense, but I am very drawn to the new shiny thing. |
Description of Changes
Fixes #374. Use poetry for dependency management (Borrowing heavily from lucyparsons#893)
Notes for Deployment
Screenshots (if appropriate)
N/A
Tests and linting
Ran unit tests and checked that development and prod instances run
I have rebased my changes on
main
just lint
passesjust test
passes