Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xvfb dependency #412

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Remove xvfb dependency #412

merged 1 commit into from
Mar 3, 2024

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Feb 27, 2024

Description of Changes

Remove xvfb dependency since we're using headless firefox

(This change depends on #411 and can be rebased once that PR has been merged)

Notes for Deployment

None!

Screenshots (if appropriate)

N/A

Tests and linting

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@sea-kelp sea-kelp requested a review from a team as a code owner February 27, 2024 07:54
@sea-kelp sea-kelp changed the title Chore/remove xvfb dependency Remove xvfb dependency Feb 27, 2024
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, nice that we can remove this!

@AetherUnbound AetherUnbound merged commit 7cc57f6 into main Mar 3, 2024
2 checks passed
@AetherUnbound AetherUnbound deleted the chore/remove-xvfb-dependency branch March 3, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants