Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warnings when Azure AI Search is not configured #14988

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

MikeAlhayek
Copy link
Member

@bleroy

This PR addressed the behavior you encountered in #14984. Basically, we register the services when the feature is enabled. But, if the configuration are missing from the file, then we show warning instead of showing action functions. Here is an example

image

image

@MikeAlhayek MikeAlhayek merged commit cbac3d5 into main Jan 4, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/asureai-config branch January 4, 2024 19:16
@bleroy
Copy link
Member

bleroy commented Jan 4, 2024

I'm sorry, I didn't have time to look at this before you merged it. The message doesn't give any clue about what needs to be configured. If you're going to the settings, chances are you're already trying to configure the search service, but don't necessarily know where to do it. The message should probably say that the Azure AI Search service needs to be specified in appsettings.json, and maybe even point to some documentation showing the exact format for that, or an example.
I'm also wondering how the feature could be used in hosted environments where you don't have access to the settings file. I'm not sure why all this can't be configured in the admin, including secrets. Then again I've been away from Orchard for a while now and I'm not sure how Core stores secrets in general.

@MikeAlhayek
Copy link
Member Author

No worries. I'll update the message once we have clear path on #14989 . Once we support the described scenario the instruction will likely change so I'll make sure it is more descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants