Move Media Indexing into a new module to simplify dependencies. #14989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastienros look at the feature, do you like the features split?
|
hishamco
approved these changes
Jan 4, 2024
src/OrchardCore.Modules/OrchardCore.Media.Indexing/OrchardCore.Media.Indexing.csproj
Outdated
Show resolved
Hide resolved
|
This time I approved with a few comments to avoid your usual comment that I'm requesting change then I might have forgotten to approve :) Good job bro |
….Media.Indexing.csproj Co-authored-by: Hisham Bin Ateya <[email protected]>
|
@hishamco I split this into 2 projects as per @sebastienros original request. |
|
Just name this OpenXML intead of MicrosoftOffice. A Word or Excel document is not bound to be from Microsoft, it could be OpenOffice too. |
hishamco
requested changes
Jan 5, 2024
src/OrchardCore.Modules/OrchardCore.Media.Indexing.Pdf/Manifest.cs
Outdated
Show resolved
Hide resolved
|
You already did 😄 |
|
I just hold my reply because this comment #14941 (comment) |
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14941