Use latest Ledger Live derivation path #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on a long-term solution that looks like it'll work. Just needs a bit more testing but it'll replace this PR. |
|
I recommend #203 over this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term "fix" that I don't really like but may be the best option right now for Ledger users.
This updates our LedgerConnector to use the same HD path as Ledger Live. Anyone who created accounts on their ledger using the previous Ledger chrome app, or MEW will be surprised that the address that shows up after connection is different. LedgerConnector currently defaults to using the path that Ledger chrome app used.
Long term, I think we should create our own
web3-reacterror for Ledger so it can try different derivations looking for an account with an ETH balance and falling back to the first account on the Ledger Live HD path. This is the behavior of Ledger Live when looking for accounts on the device.Anyone who initialized their Ledger in the last year(?) or so will use this derivation path.
More info in #21