Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger account search & employ #203

Merged
merged 3 commits into from
Sep 20, 2020
Merged

Conversation

mikeshultz
Copy link
Contributor

@mikeshultz mikeshultz commented Sep 18, 2020

This adds a customized LedgerConnector for web3-react that will attempt to lookup accounts in an intelligent way. Goes like this:

  1. Check Ledger Live derivation path, if first account has a balance, RETURN if not GOTO 2
  2. Check Ledger chrome app derivation path, if first account has balance, RETURN, if not GOTO 3
  3. Fallback to Ledger Live derivation path with an unfunded account

At some point it might be cool to add an account selector but I don't think any of these connectors support that right now?

This should replace #201
related issue: #21

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for handling these different cases elegantly. Merging this in, and adding error states to the Login Widget.

@sparrowDom sparrowDom merged commit 6bef395 into master Sep 20, 2020
@sparrowDom sparrowDom deleted the mikeshultz/ledger-path-fixen branch September 20, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants