Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

npm scripts and pre-commit hook to enforce code standards #189

Conversation

gaboesquivel
Copy link

Checklist:

  • Test your work and double check you didn't break anything
  • Update any relevant READMEs and docs

Description:

  • updates ESLint and Prettier configurations
  • adds a code linting pre-commit hook
  • makes standardjs.com with a couple custom overwrites the official code style
  • adds npm scripts for linting and formatting

Notice that I'm not updating the code files to avoid merge conflicts later, I'm just adding the npm scripts required for now.

We are going to have to define the right time to update the files so they meet the standards without conflicting with any WIP.

In this video I explain and demo the changes:
Alt text

Related to:

@gaboesquivel gaboesquivel mentioned this pull request May 17, 2018
2 tasks
@micahalcorn
Copy link
Member

micahalcorn commented May 22, 2018

@gaboesquivel great video, thanks. I like this. As you mention, it isn't easy to find a good time to merge it. I'm also hesitant about being blocked from committing if it doesn't like my format. I might try branching from this locally and trying it out for a few days. Do I need to add some format files or are they included in the branch now?

@gaboesquivel
Copy link
Author

Yes, all the configurations are in the package.json file.

@micahalcorn
Copy link
Member

micahalcorn commented Aug 10, 2018

Closing in favor of #335 but we should revisit some of the standards proposed in this PR 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants