This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Formatting Setup #335
Merged
Formatting Setup #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(when turned on, this disables switch statements)
tyleryasaka
approved these changes
Aug 10, 2018
There was a problem hiding this comment.
@micahalcorn Can you review my changes before we merge this?
After we merge I will enable TravisCI tests on this repo so that the formatting is enforced.
This was referenced Aug 10, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces code formatting similarly to OriginProtocol/origin-js#225. Could I entice anyone with trailing commas?
Feel free to propose additional rules, but let's not get too religious yet. And this PR only adds the logic to our package.json and does not yet do any of the formatting. We'll wait for @tyleryasaka to merge his changes soon before modifying likely every file in the DApp.