-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment restructure #203
Merged
Merged
Segment restructure #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-richardson
requested review from
jwass,
vcschapp,
bastiaanvanassche-tomtom and
ibnt1
May 29, 2024 18:24
ibnt1
reviewed
May 29, 2024
ibnt1
previously approved these changes
May 29, 2024
ibnt1
approved these changes
May 29, 2024
vcschapp
approved these changes
May 30, 2024
bastiaanvanassche-tomtom
approved these changes
May 30, 2024
This was referenced Jun 1, 2024
Any problem using float to model speed limit vehicle dimension values? |
vcschapp
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Flatten road wip * Flatten road wip * Fixes and update examples * Fix and add descriptions * Update docs, add deprecation comments * Fix bad merge, separate segment and conditional road properties --------- Co-authored-by: Brad Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storing road data as JSON carries a number of issues and was always considered a "stop gap" during rapid feature iteration for transportation. As we approach GA, we need to properly schematize this data. It is proposed that this also includes some structure simplification ("flattening") for ease of querying, whereas before a priority was making the JSON nicely human-readable. I've left in
road
as-is to allow us to ship both deliveries for one release to ease migration.Here is the high level schema change:
Additionally, for the non-geometry vehicle scoping block (
when: vehicle:
), we will simplify that frequently used structure as follows (note that this is a breaking change for consumers of this data):vs previously:
See additional context in this discussion
Reference
Testing
Updated all examples and counterexamples to reflect changes, including copying subproperties out of
road
to separate properties.Checklist
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Docs preview for this PR.