-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop road column #218
Drop road column #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge! Great work
So great to see this user-friendly restructuring. Just a heads up: we're developing more formal deprecation guidelines that will probably recommend a longer deprecation timeline for a change like this. We won't have the guidelines in place until after the GA release, so this is not a blocker for retiring the road column. |
Thanks Dana. Excited to see those guidelines when their finalized! |
Description
Follow-up to previous changes in #203, this drops the road column from the schema entirely in preparation for the July release. Also fixes class requirement to only apply when subtype=road, as it was previously.
Reference
Testing
Updated all examples, simple removal
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.