Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop road column #218

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Drop road column #218

merged 2 commits into from
Jun 18, 2024

Conversation

brad-richardson
Copy link
Contributor

Description

Follow-up to previous changes in #203, this drops the road column from the schema entirely in preparation for the July release. Also fixes class requirement to only apply when subtype=road, as it was previously.

Reference

  1. Segment restructure #203
  2. https://github.com/OvertureMaps/tf-transportation/issues/253

Testing

Updated all examples, simple removal

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

Copy link
Collaborator

@jwass jwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge! Great work

@danabauer
Copy link
Contributor

So great to see this user-friendly restructuring. Just a heads up: we're developing more formal deprecation guidelines that will probably recommend a longer deprecation timeline for a change like this. We won't have the guidelines in place until after the GA release, so this is not a blocker for retiring the road column.

@vcschapp
Copy link
Collaborator

So great to see this user-friendly restructuring. Just a heads up: we're developing more formal deprecation guidelines that will probably recommend a longer deprecation timeline for a change like this. We won't have the guidelines in place until after the GA release, so this is not a blocker for retiring the road column.

Thanks Dana. Excited to see those guidelines when their finalized!

@vcschapp vcschapp merged commit f08a3dc into dev Jun 18, 2024
2 checks passed
@vcschapp vcschapp deleted the drop-road branch June 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants