Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors LR #257

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Connectors LR #257

merged 6 commits into from
Aug 5, 2024

Conversation

brad-richardson
Copy link
Contributor

@brad-richardson brad-richardson commented Jul 24, 2024

Description

Adds connector ids with pre-computed linear reference values as it isn't possible to accurately compute with the current segment geometry + connector coordinate data. This value will be computed during the transportation prep process when we still have all shape points.

An added benefit here is that in many cases, connector data will no longer need to be scanned until we have additional properties on those features.

Plan is to deprecate connector_ids for removal in October which will be a prereq for declaring transportation as GA-ready.

Reference

  1. Ambiguous connectors on self intersecting/overlapping segments #219
  2. Transportation - connectors_ids vs segment's geometry #226
  3. https://github.com/OvertureMaps/tf-transportation/pull/295

Testing

Testing done during implementation

Checklist

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

ibnt1
ibnt1 previously approved these changes Jul 25, 2024
@jenningsanderson jenningsanderson merged commit 5bd9de4 into dev Aug 5, 2024
2 checks passed
@jenningsanderson jenningsanderson deleted the connectors branch August 5, 2024 15:34
@ibnt1 ibnt1 mentioned this pull request Sep 30, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants