-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectors LR #257
Merged
Merged
Connectors LR #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-richardson
force-pushed
the
connectors
branch
from
July 24, 2024 18:55
4be4799
to
c7ee7fe
Compare
ibnt1
reviewed
Jul 24, 2024
ibnt1
previously approved these changes
Jul 25, 2024
ibnt1
approved these changes
Aug 1, 2024
mojodna
approved these changes
Aug 2, 2024
jwass
approved these changes
Aug 2, 2024
PascalClarysse-TomTom
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds connector ids with pre-computed linear reference values as it isn't possible to accurately compute with the current segment geometry + connector coordinate data. This value will be computed during the transportation prep process when we still have all shape points.
An added benefit here is that in many cases, connector data will no longer need to be scanned until we have additional properties on those features.
Plan is to deprecate connector_ids for removal in October which will be a prereq for declaring transportation as GA-ready.
Reference
Testing
Testing done during implementation
Checklist
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.