Merge pull request #329 from jfmyers9/fix-query-params-tags

Fix query params on tags
PagerDuty · May 13, 2021 · 4ee8f43 · 4ee8f43
2 parents fe4ea4d + 27fc4ea
commit 4ee8f43
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tag.go b/tag.go
@@ -358,7 +358,7 @@ func getTagList(ctx context.Context, c *Client, entityType, entityID string, o L
 	}
 
 	// Make call to get all pages associated with the base endpoint.
-	if err := c.pagedGet(ctx, path+queryParms.Encode(), responseHandler); err != nil {
+	if err := c.pagedGet(ctx, path+"?"+queryParms.Encode(), responseHandler); err != nil {
 		return nil, err
 	}
 

diff --git a/tag_test.go b/tag_test.go
@@ -12,13 +12,15 @@ func TestTag_List(t *testing.T) {
 
 	mux.HandleFunc("/tags/", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
+		testEqual(t, r.URL.Query()["query"], []string{"MyTag"})
 		_, _ = w.Write([]byte(`{"tags": [{"id": "1","label":"MyTag"}]}`))
 	})
 
 	listObj := APIListObject{Limit: 0, Offset: 0, More: false, Total: 0}
 	client := &Client{apiEndpoint: server.URL, authToken: "foo", HTTPClient: defaultHTTPClient}
 	opts := ListTagOptions{
 		APIListObject: listObj,
+		Query:         "MyTag",
 	}
 	res, err := client.ListTags(opts)
 	if err != nil {