Use pointer to Priority so don't send an empty priority for incident #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the changes to the Incident struct the library now inadvertently
sends an empty priority to the API (`"priority":{}`) and for
ManageIncidents this results in a response of:
Priority id cannot be empty
To prevent sending an empty priority we can use a pointer to Priority.
Seems like a super simple fix for this - and as such I'm worried I've
missed something else.
Full discussion of this in this issue:
References: PagerDuty#135
|
Thanks for picking this up 🎉 |
atomicules
changed the title
|
thank you for contributing this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes to the Incident struct the library now inadvertently
sends an empty priority to the API (
"priority":{}) and forManageIncidents this results in a response of:
To prevent sending an empty priority we can use a pointer to Priority.
Seems like a super simple fix for this - and as such I'm worried I've
missed something else.
Full discussion of this in this issue:
References: #135