Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer to Priority so don't send an empty priority for incident #164

Commits on Aug 21, 2019

  1. Use pointer to Priority so don't send and empty priority for incident

    Due to the changes to the Incident struct the library now inadvertently
    sends an empty priority to the API (`"priority":{}`) and for
    ManageIncidents this results in a response of:
    
        Priority id cannot be empty
    
    To prevent sending an empty priority we can use a pointer to Priority.
    
    Seems like a super simple fix for this - and as such I'm worried I've
    missed something else.
    
    Full discussion of this in this issue:
    
    References: PagerDuty#135
    atomicules committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    c115f77 View commit details
    Browse the repository at this point in the history