1.20.2 Support #1088

Paul19988 · 2023-09-24T14:14:20Z

Adds support for 1.20.2 clients.
Only caveat at the moment is events that run before the player has reached the play state may need to be queued in future.

Joo200

Looks nice overall. However it could be nice if you reduce the reformatting of this PR to minify the diff.

proxy/src/main/java/com/velocitypowered/proxy/connection/MinecraftSessionHandler.java

proxy/src/main/java/com/velocitypowered/proxy/connection/backend/ConfigSessionHandler.java

proxy/src/main/java/com/velocitypowered/proxy/protocol/StateRegistry.java

api/src/main/java/com/velocitypowered/api/proxy/LoginPhaseConnection.java

.../src/main/java/com/velocitypowered/proxy/connection/backend/BackendConfigSessionHandler.java

proxy/src/main/java/com/velocitypowered/proxy/connection/backend/ConfigSessionHandler.java

proxy/src/main/java/com/velocitypowered/proxy/connection/client/ClientConfigSessionHandler.java

proxy/src/main/java/com/velocitypowered/proxy/connection/registry/ClientConfigData.java

proxy/src/main/java/com/velocitypowered/proxy/connection/registry/DataTag.java

proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientSettings.java

powercasgamer · 2023-09-24T16:24:25Z

There are a lot of unnecessary code style changes

Paul19988 · 2023-09-24T21:31:09Z

Some of the reformats are from the IDE attempting to change it to what it believes to be right & not manual intervention

astei

Please reformat these changes to use the Velocity code style (~Google code style). Left a few other comments.

proxy/build.gradle.kts

proxy/src/main/java/com/velocitypowered/proxy/connection/MinecraftConnection.java

proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java

proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/PlayPacketQueueHandler.java

proxy/src/main/java/com/velocitypowered/proxy/util/collect/CappedSet.java

NEZNAMY · 2023-09-25T15:31:54Z

Is there a pre-compiled binary available for testing?

Attack8 · 2023-09-25T15:36:17Z

Is there a pre-compiled binary available for testing?

You should compile it yourself since there is no official build
I could give you a comiled jar, but you shouldn't trust unofficial builds

IgnitingIce · 2023-09-25T16:05:34Z

Tried out this PR and experiencing this error on join:

Vislo · 2023-09-25T16:20:02Z

Tried out this PR and experiencing this error on join:

I’m not sure how to reproduce it but for some reason only happens randomly if you disconnect and try to reconnect, if you get this error connecting you will keep getting this error until you restart the Minecraft client. Hope this information helps.

totKing · 2023-10-03T14:48:24Z

https://mclo.gs/EI1AL4a
With the last push (1b07659)

Beginning it works. After a timeout, the error occurs.

Paul19988 · 2023-10-03T14:51:37Z

https://mclo.gs/EI1AL4a With the last push (1b07659)

Beginning it works. After a timeout, the error occurs.

Looks like you have a plugin on the proxy attempting to send the player a message before they've finished the configuration stage

totKing · 2023-10-03T14:53:28Z

https://mclo.gs/EI1AL4a Mit dem letzten Push ( 1b07659 )
Von Anfang an klappt es. Nach einer Zeitüberschreitung tritt der Fehler auf.

Es sieht so aus, als ob Sie ein Plugin auf dem Proxy haben, das versucht, dem Player eine Nachricht zu senden, bevor er die Konfigurationsphase abgeschlossen hat

It worked yes, after last commit from you.
If the player gets timeout, he can not enter until the proxy restart.

MVanilla · 2023-10-03T19:17:38Z

If the player moves to a different backend server during the configuration phase, an error will occur. Velocity logs
[22:43:53 INFO]: [connected player] MyName (/127.0.0.1:49436) has connected
[22:43:53 INFO]: [server connection] MyName -> survival has connected
> send MyName survival2
[22:43:54 INFO]: [server connection] MyName -> survival2 has connected
[22:43:54 INFO]: Attempting to send 0 players to survival2
[22:43:54 INFO]: [server connection] MyName -> survival has disconnected
[22:43:55 INFO]: [connected player] MyName (/127.0.0.1:49436) has disconnected
[22:43:55 INFO]: [server connection] MyName -> survival2 has disconnecte
Client logs
[22:43:55] [Render thread/WARN]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.EncoderException: java.io.IOException: Can't serialize unregistered packet
Plugins used: https://github.com/Elytrium/VelocityTools

Solution: When a player is in the configuration phase, Velocity should either deny the player from moving to another backend server or use a queue.

Are you planning on fixing this? This error occurs when using the server send or join queue plugin.
https://github.com/Elytrium/VelocityTools/releases
https://www.spigotmc.org/resources/ajqueue.78266/

yinzixie · 2023-10-06T02:28:37Z

Any progress ?

p0t4t0sandwich · 2023-10-06T05:53:07Z

Just need to be patient, if you really need it now and can't live without it, follow the readme on how to compile it.
Asking if there's any progress won't make it go faster.

Strahilchu · 2023-10-06T12:44:41Z

Come on Velocity you can do this

Phoenix616 · 2023-10-06T14:25:10Z

Please stop spamming this issue if you have nothing to improve it or feedback from your testing. If you just want updates on the progress then follow the issue/specify what notifications you want on the right, if you want to show your support then react to the posts, and if you want to test the 1.20.2 integration then build the PR (seeing as it uses gradle's wrapper it should be extremely easy to build it)

On an actual relevant note: Has the resource pack API issue been addressed/discussed @Paul19988? (See #1088 (comment)) Because I don't see anything about that in the PR. (But it's extremely hard to review with all the formatting changes :S)

DeprecatedLuke · 2023-10-07T06:30:36Z

If you run ViaVersion on the backend servers make sure you upgrade it to 4.8.1 before use if you attempt to use this branch.

Stuff working:

Previous versions
Geyser

Possible issues:

Boss bar does not get cleared when switching servers?
Slow connections have trouble switching servers ( on 1.20.2? ). No errors in console except for the normal timeout messages.
Plugin compatibility. Network I oversee only uses 1 custom-made plugin (managing backend servers, kick and send handling as well as motd) alongside Geyser.

There is no error spam and is quite usable in production.

Gerrygames · 2023-10-07T13:24:47Z

I implemented support for the backend server switching back to config state.

I also implemented a fix for the issue with the resource pack being cleared on server switch. The previously applied resource pack just gets reapplied after the server switch is done.
For some users it might be useful for the resource pack to be cleared on server switch. So we might need to find a better solution for this. However I would like to make sure we don't break the API. So this approach is the best solution for now. Also we don't know if Mojang will fix this issue with 1.20.3.

I created a PR for my changes here: Paul19988#2

From this PR PaperMC#1088

rayanbzd · 2023-10-08T22:59:51Z

I implemented support for the backend server switching back to config state.

I also implemented a fix for the issue with the resource pack being cleared on server switch. The previously applied resource pack just gets reapplied after the server switch is done. For some users it might be useful for the resource pack to be cleared on server switch. So we might need to find a better solution for this. However I would like to make sure we don't break the API. So this approach is the best solution for now. Also we don't know if Mojang will fix this issue with 1.20.3.

I created a PR for my changes here: Paul19988#2

Here is a bug report about this ressource pack issue: https://bugs.mojang.com/browse/MC-265673

bluegreensea · 2023-10-10T07:26:42Z

This PR Paul19988#3 shall recover all only had formatting codes

Phoenix616 · 2023-10-10T11:20:02Z

Just to make sure it doesn't get lost: Added a comment regarding resource pack sending after switch here

kennytv

Thanks for the hard work, everyone!

* Add version information for 1.20.1 (PaperMC#1021) * bump adventure to 4.14.0 (PaperMC#1034) * check if a plugin has a executor service (PaperMC#1038) * check if a plugin has an executor service * checkstyle * feat: add TabList#addEntries (PaperMC#987) * [ci skip] Replaced weired i with i in javadocs (PaperMC#1057) In this little patch I replaced an i which caused my build process to crash with an i * Do not track plugin channels registered per-player on the proxy (PaperMC#591) We don't need to track this information since Velocity uses the JoinGame packet, which is about as good of a server rejoin mechanism we're likely to get in vanilla Minecraft. * fix PaperMC#1062 * 1.20.2 Support (PaperMC#1088) Co-authored-by: RednedEpic <[email protected]> Co-authored-by: Gero <[email protected]> * Actually send plugin message registration to backend servers I don't see where this was ever done, and don't see how plugin messaging could of ever worked, at least within the confines of CB and co, given the fact that we never seemed to be sending this to the backend? * appease checkstyle, move back to older fix placement * Change packet decode logging prompt * Catch throwables when loading plugins (PaperMC#1098) * Several improvements and fixes for 1.20.2 (PaperMC#1097) * Send LoginAcknowledged immediately * Resend player list header/footer after backend server switched to config state * Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer * Clear boss bars, header/footer, tab list when switching client to config state * Send client settings in config state * Fix unsigned commands detected as signed (PaperMC#1082) * fix: commands flagged as signed without signed arguments * feat: improve error message for illegal protocol state. * acknowledge seen messages to server when running proxy commands (PaperMC#1100) * Implement ComponentLogger (PaperMC#1022) * Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107) * Bump netty to 4.1.100.Final (PaperMC#1067) --------- Co-authored-by: Pantera (Mad_Daniel) <[email protected]> Co-authored-by: chris <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: powercas_gamer <[email protected]> Co-authored-by: Groldi <[email protected]> Co-authored-by: Andrew Steinborn <[email protected]> Co-authored-by: Emmanuel Lampe <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: RednedEpic <[email protected]> Co-authored-by: Gero <[email protected]> Co-authored-by: Shane Freeder <[email protected]> Co-authored-by: Joo200 <[email protected]> Co-authored-by: Adrian <[email protected]>

* 1.20.2 Support (PaperMC#1088) Co-authored-by: RednedEpic <[email protected]> Co-authored-by: Gero <[email protected]> * Actually send plugin message registration to backend servers I don't see where this was ever done, and don't see how plugin messaging could of ever worked, at least within the confines of CB and co, given the fact that we never seemed to be sending this to the backend? * appease checkstyle, move back to older fix placement * Change packet decode logging prompt * Catch throwables when loading plugins (PaperMC#1098) * Several improvements and fixes for 1.20.2 (PaperMC#1097) * Send LoginAcknowledged immediately * Resend player list header/footer after backend server switched to config state * Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer * Clear boss bars, header/footer, tab list when switching client to config state * Send client settings in config state * Fix unsigned commands detected as signed (PaperMC#1082) * fix: commands flagged as signed without signed arguments * feat: improve error message for illegal protocol state. * acknowledge seen messages to server when running proxy commands (PaperMC#1100) * Implement ComponentLogger (PaperMC#1022) * Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107) * Bump netty to 4.1.100.Final (PaperMC#1067) --------- Co-authored-by: Paul <[email protected]> Co-authored-by: RednedEpic <[email protected]> Co-authored-by: Gero <[email protected]> Co-authored-by: Shane Freeder <[email protected]> Co-authored-by: Joo200 <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: Pantera (Mad_Daniel) <[email protected]>

Paul19988 and others added 8 commits September 23, 2023 17:28

initial work for 1.20.2

a38fa8d

update

0adc6f0

I *think* I made it better

e24b8da

fix client not agreeing with finish

d2c30fc

latest changes

22ee0c8

possibly fix old support

3e9fb04

More bugfixes

b014087

remove sysouts

d81c78a

Joo200 reviewed Sep 24, 2023

View reviewed changes

Redned235 added 2 commits September 24, 2023 16:07

Add a play packet queue for packets sent during the config state

1925195

Fix resource pack packet id

98013f0

powercasgamer suggested changes Sep 24, 2023

View reviewed changes

Paul19988 added 3 commits September 24, 2023 17:27

reduce amount of reformatting

252c40a

fix random spaces

2e5f7fb

remove wildcards

09a41c2

Paul19988 requested review from powercasgamer and Joo200 September 24, 2023 21:29

astei reviewed Sep 24, 2023

View reviewed changes

Paul19988 and others added 6 commits September 24, 2023 23:37

make requested changes

f5b7fa8

reformat using google style format

87cd110

fix style violations

bea6c30

remove redundent code

0a6e913

remove missed references

4908501

Ensure super.channelInactive is called in PlayPacketQueueHandler

034953e

Paul19988 added 3 commits October 3, 2023 14:55

Code style changes

fb94816

Allow serverbound config packets to pass through freely

b789257

incorporate changes recommended by Wesley1808

1b07659

Leguan16 mentioned this pull request Oct 6, 2023

1.20.2 Compatibility #1093

Closed

Support switch to config state by backend server

c076f04

Reapply resource pack after config state

fadf839

This comment was marked as spam.

Sign in to view

Gerrygames added 2 commits October 7, 2023 21:39

Add play packet queue after sending StartUpdate

f71bcfa

Make sure to decode packets with the correct state registry

3f6e69b

froobynooby added a commit to FroobWorld/Velocity that referenced this pull request Oct 8, 2023

Update 1.20.2

0be4c95

From this PR PaperMC#1088

Revert nearly all reformatting

3180764

kennytv approved these changes Oct 10, 2023

View reviewed changes

kennytv merged commit 768ecdb into PaperMC:dev/3.0.0 Oct 10, 2023
1 check passed

Xernium mentioned this pull request Oct 12, 2023

[Update][WIP] 1.20.2 #1053

Closed

enesop mentioned this pull request Oct 25, 2023

[BUG] Error decoding class net.elytrium.limboapi.injection.packet.UpsertPlayerInfoHook Direction CLIENTBOUND Protocol 1.20 State PLAY ID 3a Elytrium/LimboAPI#110

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.20.2 Support #1088

1.20.2 Support #1088

Paul19988 commented Sep 24, 2023

Joo200 left a comment

powercasgamer commented Sep 24, 2023

Paul19988 commented Sep 24, 2023

astei left a comment

NEZNAMY commented Sep 25, 2023

Attack8 commented Sep 25, 2023

IgnitingIce commented Sep 25, 2023

Vislo commented Sep 25, 2023

totKing commented Oct 3, 2023

Paul19988 commented Oct 3, 2023

totKing commented Oct 3, 2023

MVanilla commented Oct 3, 2023

yinzixie commented Oct 6, 2023

p0t4t0sandwich commented Oct 6, 2023

Strahilchu commented Oct 6, 2023

Phoenix616 commented Oct 6, 2023 •

edited

Loading

DeprecatedLuke commented Oct 7, 2023 •

edited

Loading

Gerrygames commented Oct 7, 2023 •

edited

Loading

This comment was marked as spam.

rayanbzd commented Oct 8, 2023

bluegreensea commented Oct 10, 2023

Phoenix616 commented Oct 10, 2023

kennytv left a comment

1.20.2 Support #1088

1.20.2 Support #1088

Conversation

Paul19988 commented Sep 24, 2023

Joo200 left a comment

Choose a reason for hiding this comment

powercasgamer commented Sep 24, 2023

Paul19988 commented Sep 24, 2023

astei left a comment

Choose a reason for hiding this comment

NEZNAMY commented Sep 25, 2023

Attack8 commented Sep 25, 2023

IgnitingIce commented Sep 25, 2023

Vislo commented Sep 25, 2023

totKing commented Oct 3, 2023

Paul19988 commented Oct 3, 2023

totKing commented Oct 3, 2023

MVanilla commented Oct 3, 2023

yinzixie commented Oct 6, 2023

p0t4t0sandwich commented Oct 6, 2023

Strahilchu commented Oct 6, 2023

Phoenix616 commented Oct 6, 2023 • edited Loading

DeprecatedLuke commented Oct 7, 2023 • edited Loading

Gerrygames commented Oct 7, 2023 • edited Loading

This comment was marked as spam.

rayanbzd commented Oct 8, 2023

bluegreensea commented Oct 10, 2023

Phoenix616 commented Oct 10, 2023

kennytv left a comment

Choose a reason for hiding this comment

Phoenix616 commented Oct 6, 2023 •

edited

Loading

DeprecatedLuke commented Oct 7, 2023 •

edited

Loading

Gerrygames commented Oct 7, 2023 •

edited

Loading