Skip to content

Commit

Permalink
feat good_job/shared/_secondary_navbar.erb: task bensheldon#1183
Browse files Browse the repository at this point in the history
Add border-bottom,
Remove footer class,
change the html element to a better context,
change id and data live poll region context. This is used in live_poll.js only. LivePoll.js take each data attribute to replace in the same place with new dom elements, so there is no risk to brake another page dynamism.
  • Loading branch information
Pauloparakleto committed Dec 31, 2023
1 parent 2456f8c commit 8925eb4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/views/good_job/shared/_secondary_navbar.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<footer class="footer mt-auto py-3 bg-body-tertiary border-top text-muted small" id="footer" data-live-poll-region="footer">
<nav class="mt-auto py-3 bg-body-tertiary border-bottom text-muted small" id="secondary-navbar" data-live-poll-region="secondary-navbar">
<div class="container-fluid">
<div class="row">
<div class="col-6">
Expand All @@ -10,4 +10,4 @@
</div>
</div>
</div>
</footer>
</nav>

0 comments on commit 8925eb4

Please sign in to comment.