Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show last update on top nav bar #1183

Closed
Pauloparakleto opened this issue Dec 14, 2023 · 9 comments · Fixed by #1201
Closed

Show last update on top nav bar #1183

Pauloparakleto opened this issue Dec 14, 2023 · 9 comments · Fixed by #1201

Comments

@Pauloparakleto
Copy link
Contributor

Pauloparakleto commented Dec 14, 2023 •
edited
Loading

Based on this discussion, it was suggested by @simi as an initial idea moving the footer message to the top.
image
About been not sure what to include in footer, I think should be useful author name(with link to author) and github(with link to goodjob repository).
image
@Pauloparakleto
Copy link
Contributor Author

And remember, your are doing a good job @bensheldon

Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 14, 2023
@Pauloparakleto
feat _navbar.erb: task bensheldon#1183
467a7f1 
Show last update on top navbar
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 14, 2023
@Pauloparakleto
feat locales/en.yml: task bensheldon#1183
82f079b 
Add last update on hover english translation
@bensheldon
Copy link
Owner

❤️

I think the time should always be visible so it's usable on a passive wallboard ("is that screen frozen?")

I had an idea to move the footer up to a secondary nav and it could live there: #1116

@Pauloparakleto Pauloparakleto mentioned this issue Dec 14, 2023
Closed
@Pauloparakleto
Copy link
Contributor Author

Pauloparakleto commented Dec 14, 2023 •
edited
Loading

@bensheldon printing screen on ubuntu hides the hover information, then I needed to take a picture with my phone :D
I had pull requested before reading your reply, sorry for that.

@simi
Copy link
Contributor

simi commented Dec 14, 2023

@Pauloparakleto this doesn't work for me. I would like to have info visible without any additional effort (like moving mouse).

@Pauloparakleto
Copy link
Contributor Author

@bensheldon can you please add a expected behavior since it became cumbersome what to do.

  1. Only move the footer to a new navbar?
  2. Add a new nav bar with configuration to add or remove the blocks/elements needed?
    Has the first approach conflicting with the second idea?

How to add at least what we need to this first version?

@bensheldon
Copy link
Owner

bensheldon commented Dec 20, 2023 •
edited
Loading

You're welcome to do just 1., and format the content statically.

And then 2. could come later (if you want to work on that).

@Pauloparakleto
Copy link
Contributor Author

Doing so, what would remain in the footer?

@bensheldon
Copy link
Owner

Sorry, to be explicit:

  1. Move the footer up into a secondary navbar that is immediately below the primary navbar
  2. Add the last-updated timestamp to the secondary navbar.
  3. Allow the content of the secondary navbar (entirely) to be overridden. (this comes a distant third; I realized from Adding links/metadata in dashboard #1197 that so long as it lives in its own template, it's trivially overridden by the main app)

@bensheldon
Copy link
Owner

Doing so, what would remain in the footer?

I guess it would go away entirely. I'm not sure what else would go in there (though it is nice to be clear "This is the bottom of the page")

Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat good_job/shared/_secondary_navbar.erb: task bensheldon#1183
4041ff8 
Add secondary navbar with last updated data.
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat application.html.erb: task bensheldon#1183
019db80 
Render secondary navbar below navbar.
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat en.yml: task bensheldon#1183
2456f8c 
Add secondary_navbar translation.
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat good_job/shared/_secondary_navbar.erb: task bensheldon#1183
8925eb4 
Add border-bottom,
Remove footer class,
change the html element to a better context,
change id and data live poll region context. This is used in live_poll.js only. LivePoll.js take each data attribute to replace in the same place with new dom elements, so there is no risk to brake another page dynamism.
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat locales/*.yml: task bensheldon#1183
6fb188d 
add secondary_navbar to all translations.
@Pauloparakleto Pauloparakleto mentioned this issue Dec 31, 2023
Merged
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat _footer.erb: task bensheldon#1183
c5fc2af 
Not sure about what to include in footer? What about author name and link to github repository?
Pauloparakleto added a commit to Pauloparakleto/good_job that referenced this issue Dec 31, 2023
@Pauloparakleto
feat locales/*.yml: task bensheldon#1183
c23dc66 
remove footer translation since it is simple author name and github. This is so to avoid needs of adding all translation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
3 participants
@bensheldon @simi @Pauloparakleto