Update edge-proxy (1.4.0) and pe-terminanal (1.2.0) #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedyerarm
requested changes
Aug 19, 2024
Dockerfile
Outdated
Comment on lines
3
to
4
| #ARG http_proxy="" | ||
| #ARG https_proxy="" |
There was a problem hiding this comment.
Could these be removed instead of commented out?
This requires then changes to Dockerfile: Version 27.03 of docker does not seem to take the line 3 and 4 in anymore as previously, it ignores them. This made the build fail ``` 2 warnings found (use --debug to expand): - UndefinedVar: Usage of undefined variable '$http_proxy' (line 19) - UndefinedVar: Usage of undefined variable '$https_proxy' (line 20) ``` We also had one mixed capital usage with FROM and as -< AS needs to be in capital as well. Install golang 1.20 as it's needed with updated pe-terminal and edge-proxy - they are golang 1.20 based instead of 1.18.
They are not adding value, the ARG for http proxy is documented a few lines below them anyway. Ref: review feedback from Pete.
JanneKiiskila
force-pushed
the
update-edge-proxy-and-terminal
branch
from
267ddcd
to
61ac85d
Compare
|
Rebased against master and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update edge-proxy and pe-terminal (aka edge-terminal) to the latest versions.
This requires then changes to
Dockerfile:Version 27.03 of
dockerdoes not seem to take the line 3 and 4 in anymore as previously, it ignores them. This made the build failWe also had one mixed capital usage with
FROMandas->ASneeds to be in capital as well.Install
golang 1.20as it's needed with updatedpe-terminalandedge-proxy- they are golang 1.20 based instead of 1.18.