Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update edge-proxy (1.4.0) and pe-terminanal (1.2.0) #439

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Update edge-proxy (1.4.0) and pe-terminanal (1.2.0) #439

merged 2 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. Update edge-proxy (1.4.0) and pe-terminanal (1.2.0) 

    This requires then changes to Dockerfile:

Version 27.03 of docker does not seem to take the line 3 and 4 in
anymore as previously, it ignores them. This made the build fail

```
 2 warnings found (use --debug to expand):
 - UndefinedVar: Usage of undefined variable '$http_proxy' (line 19)
 - UndefinedVar: Usage of undefined variable '$https_proxy' (line 20)
```

We also had one mixed capital usage with FROM and as -< AS needs to
be in capital as well.

Install golang 1.20 as it's needed with updated pe-terminal and
edge-proxy - they are golang 1.20 based instead of 1.18.
    @JanneKiiskila
    JanneKiiskila committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ad1100c View commit details
    Browse the repository at this point in the history

  2. Dockerfile - remove #ARGs 

    They are not adding value, the ARG for http proxy is documented
a few lines below them anyway.

Ref: review feedback from Pete.
    @JanneKiiskila
    JanneKiiskila committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    61ac85d View commit details
    Browse the repository at this point in the history