Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change QubitDevice.statistics signature #236

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Change QubitDevice.statistics signature #236

merged 3 commits into from
Nov 28, 2022

Conversation

AlbertMitjans
Copy link
Contributor

@AlbertMitjans AlbertMitjans commented Nov 25, 2022 •
edited
Loading

From:

def statistics(self, observables, shot_range=None, bin_size=None, circuit=None):

To:

def statistics(self, circuit: QuantumScript, shot_range=None, bin_size=None):

Note: observables can still be accessed inside the statistics method by using circuit.observables.

@AlbertMitjans AlbertMitjans mentioned this pull request Nov 25, 2022
Merged
@albi3ro
Update ci to newer python versions (#237)
43fe468 
* update ci to newer python versions

* remove tester file, actually stage the github folder

* update setup.py

* Apply suggestions from code review

* update readme

* bump integration tests version
albi3ro
albi3ro reviewed Nov 28, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited
Loading

Codecov Report

Merging #236 (7b139da) into master (b3abb3d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          291       291           
=========================================
  Hits           291       291
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

albi3ro
albi3ro approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@AlbertMitjans AlbertMitjans merged commit b6bc833 into master Nov 28, 2022
@AlbertMitjans AlbertMitjans deleted the change-statistics-signature branch November 28, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi3ro albi3ro albi3ro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertMitjans @albi3ro