Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci to newer python versions #237

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Update ci to newer python versions #237

merged 8 commits into from
Nov 28, 2022

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Nov 25, 2022

No description provided.

albi3ro
albi3ro commented Nov 25, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
albi3ro
albi3ro commented Nov 25, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (change-statistics-signature@da9ae40). Click here to learn what that means.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##             change-statistics-signature      #237   +/-   ##
===============================================================
  Coverage                               ?   100.00%           
===============================================================
  Files                                  ?         6           
  Lines                                  ?       291           
  Branches                               ?         0           
===============================================================
  Hits                                   ?       291           
  Misses                                 ?         0           
  Partials                               ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

timmysilv
timmysilv previously approved these changes Nov 25, 2022
View reviewed changes
@timmysilv timmysilv self-requested a review November 25, 2022 18:34
@timmysilv timmysilv dismissed their stale review November 25, 2022 18:35

will re-review after hamiltonian_expand fix from doc CI issue

@AlbertMitjans
Copy link
Contributor

AlbertMitjans commented Nov 28, 2022 •
edited
Loading

I encountered this sphinx error before! It seems like our sphinx version doesn't recognise walrus operators.

Found the error: this repo uses the action PennyLane/sphinx-action, which is a forked repo from josh146/sphinx-action. @josh146's repo used python3.7 in the past, but they recently updated it. However the changes haven't been implemented in the forked repo. I created a PR to merge the changes: PennyLaneAI/sphinx-action#1

EDIT: Fixed

AlbertMitjans
AlbertMitjans reviewed Nov 28, 2022
View reviewed changes
.github/workflows/tests.yml
@@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
python-version: [3.8, 3.9, '3.10', '3.11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python version of the integration tests also needs to be changed.

@albi3ro albi3ro changed the base branch from master to change-statistics-signature November 28, 2022 14:44
AlbertMitjans
AlbertMitjans approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@AlbertMitjans AlbertMitjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@albi3ro albi3ro merged commit 43fe468 into change-statistics-signature Nov 28, 2022
@albi3ro albi3ro deleted the ci-python-versions branch November 28, 2022 14:57
AlbertMitjans added a commit that referenced this pull request Nov 28, 2022
@AlbertMitjans @albi3ro
Change QubitDevice.statistics signature (#236)
b6bc833 
* Change statistics signature

* Update ci to newer python versions (#237)

* update ci to newer python versions

* remove tester file, actually stage the github folder

* update setup.py

* Apply suggestions from code review

* update readme

* bump integration tests version

* Update CHANGELOG.md

Co-authored-by: Christina Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertMitjans AlbertMitjans AlbertMitjans approved these changes

@timmysilv timmysilv Awaiting requested review from timmysilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albi3ro @AlbertMitjans @timmysilv