-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podlators: load PerlIO before trying to use its functions #22165
Conversation
Cherry-picked from rra/podlators#28 Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its version was bumped. Fixes Perl#21841
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me as podlators maintainer.
The fix looks good to me, but I'd like it if someone commits to uncustomizing things after 5.40 comes out. This step is often forgotten (or done incompletely) creating extra work later when someone has to figure out what's going on. |
An alternative solution may be to release a 4.15 release with only this fix (that wouldn't be indexed as it's version is lower than the current highest), and sync that to blead. |
This is causing the following warning in MakeMaker
That line does
Either we need to include version evals on the podlator sites, or it needs to call the VERSION method on that line. Or both. |
I don't think calling Also, our $VERSION = '5.01_01';
$VERSION =~ tr/_//d; suffice? |
Cherry-picked from rra/podlators#28
Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its version was bumped.
Fixes #21841