Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podlators: load PerlIO before trying to use its functions #22165

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

xenu
Copy link
Member

@xenu xenu commented Apr 22, 2024

Cherry-picked from rra/podlators#28

Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its version was bumped.

Fixes #21841

Cherry-picked from rra/podlators#28

Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its
version was bumped.

Fixes Perl#21841
Copy link
Contributor

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me as podlators maintainer.

@Leont
Copy link
Contributor

Leont commented Apr 22, 2024

The fix looks good to me, but I'd like it if someone commits to uncustomizing things after 5.40 comes out. This step is often forgotten (or done incompletely) creating extra work later when someone has to figure out what's going on.

@Leont
Copy link
Contributor

Leont commented Apr 22, 2024

An alternative solution may be to release a 4.15 release with only this fix (that wouldn't be indexed as it's version is lower than the current highest), and sync that to blead.

@haarg haarg merged commit 7a2df06 into Perl:blead Apr 25, 2024
30 checks passed
@Leont
Copy link
Contributor

Leont commented Apr 28, 2024

This is causing the following warning in MakeMaker

Argument "5.01_01" isn't numeric in numeric ge (>=) at /home/leont/perl5/perlbrew/perls/perl-5.39.10/lib/5.39.10/ExtUtils/Command/MM.pm line 127.

That line does

delete $options{utf8} unless $Pod::Man::VERSION >= 2.17;

Either we need to include version evals on the podlator sites, or it needs to call the VERSION method on that line. Or both.

@mauke
Copy link
Contributor

mauke commented Apr 28, 2024

I don't think calling ->VERSION would make a difference here.

Also, eval is massive overkill. Wouldn't

our $VERSION = '5.01_01';
$VERSION =~ tr/_//d;

suffice?

@Leont
Copy link
Contributor

Leont commented Apr 28, 2024

Also, eval is massive overkill. Wouldn't tr suffice?

Yeah that's exactly what @haarg ended up doing in 22180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with unicode in Getopt::Long HelpMessage() in perl 5.38
5 participants