Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load PerlIO before trying to use its functions #28

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

haarg
Copy link
Contributor

@haarg haarg commented Mar 14, 2024

No description provided.

@rra
Copy link
Owner

rra commented Mar 15, 2024

Did you encounter a problem that is fixed by this PR? My understanding is that PerlIO is not a regular Perl module and there's no need to import it before using functions in the PerlIO namespace. I just looked at PerlIO.pm in Perl 5.38.2 and it appears that require PerlIO; would not do anything.

@haarg
Copy link
Contributor Author

haarg commented Mar 15, 2024

This fixes #25.

The constant PerlIO::F_UTF8 is only available once PerlIO.pm is loaded.

@rra
Copy link
Owner

rra commented Mar 15, 2024

Oh! Doh. Yes, thank you.

@rra rra merged commit 1667094 into rra:main Mar 15, 2024
14 checks passed
@youpong
Copy link

youpong commented Mar 20, 2024

The bug appears to have been fixed. Thank you, @haarg.

@haarg haarg deleted the load-perlio branch April 18, 2024 17:46
xenu added a commit to xenu/perl5 that referenced this pull request Apr 22, 2024
Cherry-picked from rra/podlators#28

Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its
version was bumped.

Fixes Perl#21841
haarg pushed a commit to Perl/perl5 that referenced this pull request Apr 25, 2024
Cherry-picked from rra/podlators#28

Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its
version was bumped.

Fixes #21841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants