Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XCode 13 & Android 12 #164

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

manualexSP
Copy link

Changes:

  • [ x] adds two timeouts to fix firmware uploads for iOS 13.
    It is the same fix as this other fork but on a later version of the trunk.
  • [ x] Android retries configurable retries.
  • [ x] Android max MTU configurable
  • [ x] Update Android to the latest SDK & Gradle
  • [ x] Update no.nordicsemi.android:dfu:2.0.1 to fix Android 12 problems

@manualexSP manualexSP marked this pull request as draft May 6, 2022 06:14
@manualexSP manualexSP marked this pull request as ready for review May 6, 2022 06:15
@vkourtis
Copy link

vkourtis commented Jun 9, 2022

Confirming that this fixes #166.

For now I added a patch to use no.nordicsemi.android:dfu:2.0.1 and this was all I needed.

@Cantinaband
Copy link

Having some troubles with Android 12. Would be great to have this PR released

@Hassaan68
Copy link

Confirming that this fixes #166.

For now I added a patch to use no.nordicsemi.android:dfu:2.0.1 and this was all I needed.

hi @vkourtis. can you please explain the steps needed in more detail?

@vkourtis
Copy link

vkourtis commented Nov 4, 2022

Confirming that this fixes #166.
For now I added a patch to use no.nordicsemi.android:dfu:2.0.1 and this was all I needed.

hi @vkourtis. can you please explain the steps needed in more detail?

Sure! You need to use patch-package and add a file under your patches folder with filename react-native-nordic-dfu+3.2.1.patch and the following content:

diff --git a/node_modules/react-native-nordic-dfu/android/build.gradle b/node_modules/react-native-nordic-dfu/android/build.gradle
index eb225b1..d7fa73e 100644
--- a/node_modules/react-native-nordic-dfu/android/build.gradle
+++ b/node_modules/react-native-nordic-dfu/android/build.gradle
@@ -38,6 +38,6 @@ repositories {
 
 dependencies {
     implementation 'com.facebook.react:react-native:+'
-    implementation 'no.nordicsemi.android:dfu:1.8.0'
+    implementation 'no.nordicsemi.android:dfu:2.0.1'
 }

This assumes that you use the latest version of react-native-nordic-dfu, 3.2.1. If not, I suggest to update this package before applying this patch.

@kakonyitibor
Copy link

kakonyitibor commented Nov 22, 2022

Hello,
I have tried my app with this patch on Android12.
It doesn't crash anymore on startDfu (unlike when using the original repo, issue #166 ), but the process gets stuck in the DFU_PROCESS_STARTING state, then throws GATT ERROR. (I don't have this problem with older Android versions. )
Do you have any idea?
Thank you!

Edit: turned out that nRF Connect mobile produces a similar behaviour with the Android12 phone I'm using, so this might be a device-specific bug in the Nordic Android DFU library.

@RuchiraSwarnapriya
Copy link

Hello,

I also tried my app with this patch on Android 12, now app crashing without opening. Can someone help me to resolve this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.