-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multiple sources #1
Comments
I personally don't plan on doing it for multiple reason: I would surely appreciate if you could work together on this plugin. I am French also. |
Hi , I agree multiple source can be a very low priority feature, I'm trying to make my videos webm only from now on. I then search how to show a message when the device ( mainly from apple) , like " You cannot play WEBM on this device , please instal THIS or go HERE to add webm support. this would be done in the videojs itself I guess ? the issue on the videojs side is here : |
I think about it and I have a solution. |
Great solution for multiple sources ! I'm trying to propose a patch for easy solutions when in webm-only mode. I know for IOS users, too bad for them. |
Work in progress, Initial support for multiple sources |
Thanks for pulling. Thanks Norbert |
An array '$videos' is define with multiple files of the same videos if found.
The template language is smarty, you can find 2 examples: https://github.com/xbgmsharp/piwigo-videojs/blob/master/admin/admin_sync.tpl#L56 Also MP4 format need to be first so the array need to sort.
|
Hi, I don't think we need to sort the array first, since videojs does accept the formats in any order, at least as far as I see. Could we determine the format from the extension? Probably that is above the smarty template language and it is easier to put the code in the videos array generation routine and let it only be read out by the template. I will look into it. |
Hi, I will report more testing |
Great looking for it. |
Merge pull request #34 from monadh/master
ffprobe may provide the longitude value as: " location : +60.1568+024.8577/ " Hence, this will result in a piwigo-videojs longitude value of: " longitude: +024.8577/ " That will lead to the following fatal error: " Fatal error: Uncaught mysqli_sql_exception: Data truncated for column 'longitude' at row 1 in /app/www/public/include/dblayer/functions_mysqli.inc.php:132 Stack trace: #0 /app/www/public/include/dblayer/functions_mysqli.inc.php(132): mysqli->query() Piwigo#1 /config/www/plugins/piwigo-videojs/admin/admin_photo.php(126): pwg_query() Piwigo#2 /app/www/public/admin/plugin.php(53): include_once('...') Piwigo#3 /app/www/public/admin.php(345): include('...') Piwigo#4 {main} thrown in /app/www/public/include/dblayer/functions_mysqli.inc.php on line 132 " Fixes: 5e9b209 (Add support for exiftool and ffprobe) Closes: Piwigo#167 Suggested-by: chrud
Support one or more sources like videoJs can do it :
this would allow to upload both files webm and mp4 ( but synchronizing might generate duplicates )
The text was updated successfully, but these errors were encountered: