Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP warning when creating thumbnails for short movied #3

Closed
nikolauskrismer opened this issue Jun 19, 2013 · 1 comment
Closed

PHP warning when creating thumbnails for short movied #3

nikolauskrismer opened this issue Jun 19, 2013 · 1 comment

Comments

@nikolauskrismer
Copy link

For some of my movies I get a php warning on thumbnail creation:

For some of my movies I get a php warning:

Warning: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error: in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 56 Warning: imagecreatefromjpeg(): './galleries/2012/2012-07-21/pwg_representative/00015.jpg' is not a valid JPEG file in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 56 Warning: imagesx() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 70 Warning: imagesy() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 71 Warning: imagecreatetruecolor(): Invalid image dimensions in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 76 Warning: imagecolorallocate() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 78 Warning: imagecolorallocate() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 79 Warning: imagecopy() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 98 Warning: imagejpeg() expects parameter 1 to be resource, boolean given in /media/Niko/www/piwigo/plugins/piwigo-videojs/include/function_frame.php on line 105

I guess this is because the movie which causes the error is only 1 second on length, but thumbnail creation should use image at second 2. Maybe a fallback would be great here (take last image if movie is not as long as needed).

@xbgmsharp
Copy link
Collaborator

Fix: compare movie length against the requested second and ensure file exist.

tanty pushed a commit to tanty/piwigo-videojs that referenced this issue May 30, 2023
ffprobe may provide the longitude value as:

  "
    location        : +60.1568+024.8577/
  "

Hence, this will result in a piwigo-videojs longitude value of:

  "
    longitude: +024.8577/
  "

That will lead to the following fatal error:

  "
    Fatal error: Uncaught mysqli_sql_exception: Data truncated for column 'longitude' at row 1 in /app/www/public/include/dblayer/functions_mysqli.inc.php:132 Stack trace: #0 /app/www/public/include/dblayer/functions_mysqli.inc.php(132): mysqli->query() Piwigo#1 /config/www/plugins/piwigo-videojs/admin/admin_photo.php(126): pwg_query() Piwigo#2 /app/www/public/admin/plugin.php(53): include_once('...') Piwigo#3 /app/www/public/admin.php(345): include('...') Piwigo#4 {main} thrown in /app/www/public/include/dblayer/functions_mysqli.inc.php on line 132
  "

Fixes: 5e9b209 (Add support for exiftool and ffprobe)
Closes: Piwigo#167

Suggested-by: chrud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants