Multiple tree flow fix

[ankitecd]

Changes in this pull request:

• Fixing multiple tree flow

[norbertschuler]

@ankitecd is this already ready to be tested?

[ankitecd]

@ankitecd is this already ready to be tested?

No, not yet

[norbertschuler]

• The GeoJson export just exports the polygon, no sample trees or other information, right?

[norbertschuler]

We should add check for all the other usages of the camera as well (I got a problem registering sample trees):

[ankitecd]

I tested multiple tree registrations with tags and got the following issues:

* [ ]  For the registered trees there is no possibility to enter a tag and so nothing is send with the API call to upload the registered trees and `tag: null` is returned - should it be possible to tag these trees?

* [ ]  For the sample trees if you enter the tag in the dialog at the same time when entering the diameter and height the tag gets send with the API call to upload the sample tree, but if you enter the tag later on the review page, it is not send anymore with the API call to upload a sample tree:

1. It is not possible to to tag multiple trees with one tag so tag for multiple tree is not required.
2. Fixed in latest commit.

[norbertschuler]

• I tested entering the data without being logged in in cm/m and then logged in with my account having countryCode=US and seeing the converted values - I miss some rounding with two places behind the dot (xxx.xx) for the inches/feet values:

[norbertschuler]

• The review page for a sample tree is not showing the photo if it is available.

[norbertschuler]

• The picture (confirmation for a location while specifying a polygon or just a hint for a picture) is only showing the lower part of the image with the woman - is that correct?

[norbertschuler]

• Species list has a green link for every number of species, but the link has not functionality (we should either remove the link or add the missing functionality):

[norbertschuler]

• I am missing the inch/feet conversion in the sample tree detail screen - or in the list - but at least these both differ:

!

[norbertschuler]

• If I enter values 1 for height and diameter in feet and inches, on the review screen they are shown differently. So either the input or the output is wrong here too:

[norbertschuler]

• If I enter values 1 for height and diameter in feet and inches, on the review screen they are shown differently. So either the input or the output is wrong here too:

• Now 1 inch / 1 feet got converted into this on the review screen - even with some calculations a value of 1 should not be converted into a value of 0.98:

[norbertschuler]

• Species list has a green link for every number of species, but the link has not functionality (we should either remove the link or add the missing functionality):

• There is a similar small UI issue on the species selection screen as the species is written in green color, but is not a link to do anything clicking on it.

[norbertschuler]

• If you do not change your location between point A and B, you get an alert, but it is shown on the next screen when you are ask to take picture and you can just click it away and ignore it - this is not really a bug, but also maybe not the wanted behavior @sagararyal:

• Not translating "Location" into "Standort" on the screen asking to take a photo is a bug :-)

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
44 Code Smells

No Coverage information
5.9% Duplication

[norbertschuler]

All my issues seem to be solved, but I got 401 error while uploading the test data accumulated today and yesterday. Hitting the upload button twice seems to help, but I wonder how the OAuth token could get outdated between different uploads within a few seconds. Once I also got the error Bugsnag could not notify: error must be of type Error which might indicate that the parameter given to bugsnag.notify() somewhere in the code has the wrong type (also important to check for #262)?

I approved this PR now as I think these issues can be done in new PR not blocking this merge.