Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bugsnags #262

Closed
wants to merge 4 commits into from
Closed

added bugsnags #262

wants to merge 4 commits into from

Conversation

tejassonar
Copy link
Contributor

Changes in this pull request:

  • Added bugsnags in all over the app

@ankitecd

@norbertschuler
Copy link
Collaborator

I have not yet tested. Do we want all these notifications at Bugsnag? If yes, it looks ok for me.

@norbertschuler
Copy link
Collaborator

In #210 I got the error Bugsnag could not notify: error must be of type Error which might indicate that the parameter given to bugsnag.notify() somewhere in the code has the wrong type. Can we test this here, once develop is merged into this PR and all the conflicts got solved (maybe just do the changes once more if there are too much conflicts).

@tejassonar
Copy link
Contributor Author

In #210 I got the error Bugsnag could not notify: error must be of type Error which might indicate that the parameter given to bugsnag.notify() somewhere in the code has the wrong type. Can we test this here, once develop is merged into this PR and all the conflicts got solved (maybe just do the changes once more if there are too much conflicts).

Sure. I'll merge develop into this PR and will see what's the issue exactly. Also, I'll need to add more bugsnag.notify() after merging with develop, if they aren't already added.

@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@norbertschuler
Copy link
Collaborator

I am afraid this pull requests is outdated and needs a lot of conflicts to be solved (or done newly?).

@norbertschuler
Copy link
Collaborator

@tejassonar should we close this?

@tejassonar
Copy link
Contributor Author

@tejassonar should we close this?

Yes, I think we should.

@norbertschuler norbertschuler deleted the feature/bugsnag branch May 28, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants