feat: make the storage key reactive #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(will prevent unneccessary mounting/unmounting of storage)
- tests if storage is properly mounted and unmounted if the key changes
|
Thanks for the PR! :D |
louisgv
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 by making the useStorage
keyparameter reactive.I added a useRef to track the current
renderValuewithin the hook. This avoids us from adding dependencies to some of the callbacks and so it prevents needless un-mounting and re-mounting of the storage.I added a test to ensure the storage unmounts and re-mounts properly when the key changes.
Note: this only makes the string
keyreactive, not a custom Storage paramater that's passed in. If someone wants to switch between different Storages (sync and local, for example) using the same hook, it won't happen automatically since the Storage parameter is not reactive (this might be another PR if I can figure out how to make it happen)