Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make the storage key reactive #42

Merged
merged 6 commits into from
Sep 8, 2023
Merged

feat: make the storage key reactive #42

merged 6 commits into from
Sep 8, 2023

Commits on Aug 18, 2023

  1. make the storage key reactive

    @fa-sharp
    fa-sharp committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5cb4447 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Merge branch 'PlasmoHQ:main' into plasmo-storage-reactive-key

    @fa-sharp
    fa-sharp committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    1483c86 View commit details
    Browse the repository at this point in the history

  2. use a ref to minimize dependencies of callbacks 

    (will prevent unneccessary mounting/unmounting of storage)
    @fa-sharp
    fa-sharp committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b59570a View commit details
    Browse the repository at this point in the history

  3. remove unnecessary import

    @fa-sharp
    fa-sharp committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    7a6dcd4 View commit details
    Browse the repository at this point in the history

  4. flesh out test for reactive key 

    - tests if storage is properly mounted and unmounted if the key changes
    @fa-sharp
    fa-sharp committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8ac2617 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'main' into plasmo-storage-reactive-key

    @louisgv
    louisgv committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d1eec33 View commit details
    Browse the repository at this point in the history