-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hidden visibility for symbols for non-windows platforms #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sorin Vatasoiu <[email protected]>
svatasoiu
requested review from
robambalu,
AdamGlustein,
alexddobkin,
ptomecek and
timkpaine
as code owners
July 17, 2024 13:25
timkpaine
added
lang: c++
Issues and PRs related to the C++ codebase
type: enhancement
Issues and PRs related to improvements to existing features
labels
Jul 17, 2024
Signed-off-by: Sorin Vatasoiu <[email protected]>
cannot reproduce the mac os build failures locally. I was able to successfully compile+run all tests on Python3.12 linux w/ clang 18.1.8, as well as clang 16.0.6 on mac os 13; but GH seems to be failing on clang 16.0.6 + OSX 12+14 builds with a mysterious error: make: *** [test-py] Abort trap: 6 |
…visible Signed-off-by: Sorin Vatasoiu <[email protected]>
svatasoiu
force-pushed
the
hidden-visibility-non-windows
branch
2 times, most recently
from
July 26, 2024 22:41
eec76ac
to
60e55c4
Compare
…rrow type Signed-off-by: Sorin Vatasoiu <[email protected]>
svatasoiu
force-pushed
the
hidden-visibility-non-windows
branch
from
July 30, 2024 17:57
60e55c4
to
91b2516
Compare
Before:
After:
|
robambalu
requested changes
Jul 30, 2024
…P_PUBLIC/LOCAL* Signed-off-by: Sorin Vatasoiu <[email protected]>
robambalu
reviewed
Jul 30, 2024
Signed-off-by: Sorin Vatasoiu <[email protected]>
Pls just make sure to squash commits when merging |
robambalu
approved these changes
Jul 30, 2024
AdamGlustein
added a commit
that referenced
this pull request
Nov 13, 2024
…341)" This reverts commit 4153d01. Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
added a commit
that referenced
this pull request
Nov 13, 2024
* Revert "Use hidden visibility for symbols for non-windows platforms (#341)" This reverts commit 4153d01. Signed-off-by: Adam Glustein <[email protected]> * Remove CSP_PUBLIC from autogen build Signed-off-by: Adam Glustein <[email protected]> --------- Signed-off-by: Adam Glustein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lang: c++
Issues and PRs related to the C++ codebase
type: enhancement
Issues and PRs related to improvements to existing features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to avoid polluting our .so's with visible symbols that might clash with other libraries when CSP is imported. default is basically public for gcc+clang, so this PR changes it to hidden (Windows does the opposite, the default is essentially publicly visible in the DLL symbol table)
reference: https://gcc.gnu.org/wiki/Visibility